Skip to content

Fix invalid python imports in pytests#1455

Merged
ilyamandel merged 3 commits into
devfrom
fix_invalid_python_imports
Mar 6, 2026
Merged

Fix invalid python imports in pytests#1455
ilyamandel merged 3 commits into
devfrom
fix_invalid_python_imports

Conversation

@avivajpeyi

@avivajpeyi avivajpeyi commented Feb 18, 2026

Copy link
Copy Markdown
Collaborator

Close #1454

  1. Fixed pytest import errors by removing from py_tests... style imports.
  2. Replaced silent cosmic-integration import fallbacks with a clear setup error message (install with -e . / -e '.[dev]').
  3. Made mass-range handling work for tiny test datasets and aligned DCO naming (BHBH).

@avivajpeyi
avivajpeyi marked this pull request as draft February 18, 2026 03:54
@github-actions

Copy link
Copy Markdown

✅ COMPAS Build Successful!

Item Value
Commit 28c01b7
Logs View workflow

Detailed Evolution Plot

Click to view evolution plot


Generated by COMPAS CI

@github-actions

Copy link
Copy Markdown

✅ COMPAS Build Successful!

Item Value
Commit 0f76ac0
Logs View workflow

Detailed Evolution Plot

Click to view evolution plot


Generated by COMPAS CI

@avivajpeyi
avivajpeyi marked this pull request as ready for review February 18, 2026 04:52

@LiekeVanSon LiekeVanSon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Note sure, but I might have been to blame introducing this in the latest update to the CosmicIntegration scripts, if so, sorry, but thanks for cleaning this up!

Related: do we maybe want a changelog for the python scripts as well? (this might help prevent such incidents in the future)

@ilyamandel ilyamandel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed check -- looks great, @avivajpeyi !
(@jeffriley explained that some of these are reverting previous incorrect changes, where your comments on a PR didn't come through somehow... :( )

@ilyamandel
ilyamandel merged commit 25d5824 into dev Mar 6, 2026
4 checks passed
@ilyamandel
ilyamandel deleted the fix_invalid_python_imports branch March 6, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python import path / working-directory issue in conftest.py in py_test ?-> maybe GitHub check do not complete due to this

3 participants