Skip to content

Defect repair: Fix for issue 1441 #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffriley merged 3 commits into from
Mar 15, 2026
+15 −93
Merged

Defect repair: Fix for issue 1441 #1465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
838b3fc
Defect repair: Fix for issue 1441: vector out-of-bounds access in Log…
jeffriley Mar 15, 2026
8d50fab
Update COMPAS.css - fix typo
jeffriley Mar 15, 2026
b337e66
Update changelog.h - fix typo
jeffriley Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions online-docs/_static/css/COMPAS.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,11 @@
}

/* left align tables (default seems to be centred) */
/* disable for now - until I work out the best fix for issue #1424
table {
float: left;
}
*/

.boldtext {
font-weight: bold !important;
Expand Down
94 changes: 2 additions & 92 deletions ...ages/User guide/COMPAS output/standard-logfiles-record-specification-binary.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ Binary Properties
* - Header String:
- CE_Event_Counter

.. raw:: html
<div style="clear: both;"></div>

.. _binary-props-D:

:ref:`Back to Top <binary-props-top>`
Expand Down Expand Up @@ -120,9 +117,6 @@ Binary Properties
* - Header String:
- dT

.. raw:: html
<div style="clear: both;"></div>

.. _binary-props-E:

:ref:`Back to Top <binary-props-top>`
Expand Down Expand Up @@ -256,10 +250,7 @@ Binary Properties
Refer to :doc:`../Handling errors/evolution-status-table` for possible values.
* - Header Strings:
- Evolution_Status

.. raw:: html
<div style="clear: both;"></div>


.. _binary-props-F:

.. _binary-props-G:
Expand Down Expand Up @@ -301,9 +292,6 @@ Binary Properties
- Flag to indicate if either star overflows its Roche lobe immediately following common envelope event.
* - Header String:
- Immediate_RLOF>CE

.. raw:: html
<div style="clear: both;"></div>

.. _binary-props-J:

Expand Down Expand Up @@ -495,10 +483,7 @@ Binary Properties
- Flag to indicate if the binary compact remnants merge within a Hubble time.
* - Header String:
- Merges_Hubble_Time

.. raw:: html
<div style="clear: both;"></div>


.. _binary-props-N:

.. _binary-props-O:
Expand Down Expand Up @@ -601,9 +586,6 @@ Binary Properties
Will be 0.0 for unbound binaries.
* - Header String:
- Orbital_Velocity<SN

.. raw:: html
<div style="clear: both;"></div>

.. _binary-props-P:

Expand Down Expand Up @@ -983,9 +965,6 @@ Binary Properties
- Stellar type (per :cite:`Hurley2000`) of the primary star immediately after RLOF.
* - Header String:
- Stellar_Type(1)>MT

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as RLOF_POST_MT_STAR1_STELLAR_TYPE_NAME. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`
Expand All @@ -1005,9 +984,6 @@ but not both. If both are printed then the file will contain two columns with th
- Stellar type (per :cite:`Hurley2000`) of the primary star immediately after RLOF.
* - Header String:
- Stellar_Type(1)>MT

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as RLOF_POST_MT_STAR1_STELLAR_TYPE. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`
Expand All @@ -1027,9 +1003,6 @@ but not both. If both are printed then the file will contain two columns with th
- Stellar type (per :cite:`Hurley2000`) of the secondary star immediately after RLOF.
* - Header String:
- Stellar_Type(2)>MT

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as RLOF_POST_MT_STAR2_STELLAR_TYPE_NAME. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`
Expand All @@ -1049,9 +1022,6 @@ but not both. If both are printed then the file will contain two columns with th
- Stellar type (per :cite:`Hurley2000`) of the secondary star immediately after RLOF.
* - Header String:
- Stellar_Type(2)>MT

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as RLOF_POST_MT_STAR2_STELLAR_TYPE. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`
Expand Down Expand Up @@ -1296,9 +1266,6 @@ but not both. If both are printed then the file will contain two columns with th
- Stellar type (per :cite:`Hurley2000`) of the primary star at the onset of RLOF.
* - Header String:
- Stellar_Type(1)<MT

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as RLOF_PRE_MT_STAR1_STELLAR_TYPE_NAME. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`
Expand All @@ -1318,9 +1285,6 @@ but not both. If both are printed then the file will contain two columns with th
- Stellar type (per :cite:`Hurley2000`) of the primary star at the onset of RLOF.
* - Header String:
- Stellar_Type(1)<MT

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as RLOF_PRE_MT_STAR1_STELLAR_TYPE. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`
Expand All @@ -1340,9 +1304,6 @@ but not both. If both are printed then the file will contain two columns with th
- Stellar type (per :cite:`Hurley2000`) of the secondary star at the onset of RLOF.
* - Header String:
- Stellar_Type(2)<MT

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as RLOF_PRE_MTvSTAR2_STELLAR_TYPE_NAME. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`
Expand All @@ -1362,9 +1323,6 @@ but not both. If both are printed then the file will contain two columns with th
- Stellar type (per :cite:`Hurley2000`) of the secondary star at the onset of RLOF.
* - Header String:
- Stellar_Type(2)<MT

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as RLOF_PRE_MT_STAR2_STELLAR_TYPE. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`
Expand Down Expand Up @@ -1529,9 +1487,6 @@ but not both. If both are printed then the file will contain two columns with th
* - Header String:
- RocheLobe(2)<CE

.. raw:: html
<div style="clear: both;"></div>

.. _binary-props-S:

:ref:`Back to Top <binary-props-top>`
Expand Down Expand Up @@ -1649,9 +1604,6 @@ but not both. If both are printed then the file will contain two columns with th
* - Header String:
- SemiMajorAxis<SN

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as SEMI_MAJOR_AXIS_PRE_SUPERNOVA_RSOL. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`

Expand All @@ -1671,9 +1623,6 @@ but not both. If both are printed then the file will contain two columns with th
* - Header String:
- SemiMajorAxis<SN

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as SEMI_MAJOR_AXIS_PRE_SUPERNOVA. It is expected that one or the other is printed in any file, but
not both. If both are printed then the file will contain two columns with the same header string.`

Expand Down Expand Up @@ -1709,9 +1658,6 @@ not both. If both are printed then the file will contain two columns with the sa
* - Header String:
- SemiMajorAxis

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as SEMI_MAJOR_AXIS_RSOL. It is expected that one or the other is printed in any file, but not both.
If both are printed then the file will contain two columns with the same header string.`

Expand All @@ -1731,9 +1677,6 @@ If both are printed then the file will contain two columns with the same header
* - Header String:
- SemiMajorAxis

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as SEMI_MAJOR_AXIS. It is expected that one or the other is printed in any file, but not both. If both
are printed then the file will contain two columns with the same header string.`

Expand Down Expand Up @@ -1817,9 +1760,6 @@ are printed then the file will contain two columns with the same header string.`
* - Header String:
- Stellar_Type(1)>CE

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as STELLAR_TYPE_NAME_1_POST_COMMON_ENVELOPE. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`

Expand All @@ -1839,9 +1779,6 @@ but not both. If both are printed then the file will contain two columns with th
* - Header String:
- Stellar_Type(1)<CE

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as STELLAR_TYPE_NAME_1_PRE_COMMON_ENVELOPE. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`

Expand All @@ -1861,9 +1798,6 @@ but not both. If both are printed then the file will contain two columns with th
* - Header String:
- Stellar_Type(2)>CE

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as STELLAR_TYPE_NAME_2_POST_COMMON_ENVELOPE. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`

Expand All @@ -1883,9 +1817,6 @@ but not both. If both are printed then the file will contain two columns with th
* - Header String:
- Stellar_Type(2)<CE

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as STELLAR_TYPE_NAME_2_PRE_COMMON_ENVELOPE. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`

Expand All @@ -1905,9 +1836,6 @@ but not both. If both are printed then the file will contain two columns with th
* - Header String:
- Stellar_Type(1)>CE

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as STELLAR_TYPE_1_POST_COMMON_ENVELOPE. It is expected that one or the other is printed in any file,
but not both. If both are printed then the file will contain two columns with the same header string.`

Expand All @@ -1927,9 +1855,6 @@ but not both. If both are printed then the file will contain two columns with th
* - Header String:
- Stellar_Type(1)<CE

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as STELLAR_TYPE_1_PRE_COMMON_ENVELOPE. It is expected that one or the other is printed in any file, but not
both. If both are printed then the file will contain two columns with the same header string.`

Expand All @@ -1949,9 +1874,6 @@ both. If both are printed then the file will contain two columns with the same h
* - Header String:
- Stellar_Type(2)>CE

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as STELLAR_TYPE_2_POST_COMMON_ENVELOPE. It is expected that one or the other is printed in any file, but not
both. If both are printed then the file will contain two columns with the same header string.`

Expand All @@ -1971,9 +1893,6 @@ both. If both are printed then the file will contain two columns with the same h
* - Header String:
- Stellar_Type(2)<CE

.. raw:: html
<div style="clear: both;"></div>

`Note that this property has the same header string as STELLAR_TYPE_2_PRE_COMMON_ENVELOPE. It is expected that one or the other is printed in any file, but not
both. If both are printed then the file will contain two columns with the same header string.`

Expand Down Expand Up @@ -2119,9 +2038,6 @@ both. If both are printed then the file will contain two columns with the same h
* - Header String:
- SystemicVelocityZ

.. raw:: html
<div style="clear: both;"></div>

.. _binary-props-T:

:ref:`Back to Top <binary-props-top>`
Expand Down Expand Up @@ -2286,9 +2202,6 @@ both. If both are printed then the file will contain two columns with the same h
* - Header String:
- Energy_Total

.. raw:: html
<div style="clear: both;"></div>

.. _binary-props-U:

:ref:`Back to Top <binary-props-top>`
Expand All @@ -2309,9 +2222,6 @@ both. If both are printed then the file will contain two columns with the same h
* - Header String:
- Unbound

.. raw:: html
<div style="clear: both;"></div>

.. _binary-props-V:

.. _binary-props-W:
Expand Down
6 changes: 6 additions & 0 deletions src/Log.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2805,6 +2805,7 @@ LogfileDetailsT Log::StandardLogFileDetails(const LOGFILE p_Logfile, const strin

if (p_Logfile == LOGFILE::BSE_SWITCH_LOG) { // BSE Switch Log
fileDetails.propertyTypes.push_back(TYPENAME::INT); // append property typename
fileDetails.stringTypes.push_back(STRING_QUALIFIER::FIXED_LENGTH); // append string type - default is fixed length
fileDetails.hdrStrings.push_back("Star_Switching"); // append header string for field
fileDetails.unitsStrings.push_back("-"); // append units string for field
fileDetails.typeStrings.push_back("INT"); // append type string for field
Expand All @@ -2815,6 +2816,9 @@ LogfileDetailsT Log::StandardLogFileDetails(const LOGFILE p_Logfile, const strin
fileDetails.propertyTypes.push_back(TYPENAME::STELLAR_TYPE); // append property typename
fileDetails.propertyTypes.push_back(TYPENAME::STELLAR_TYPE); // append property typename

fileDetails.stringTypes.push_back(STRING_QUALIFIER::FIXED_LENGTH); // append string type - default is fixed length
fileDetails.stringTypes.push_back(STRING_QUALIFIER::FIXED_LENGTH); // append string type - default is fixed length

fileDetails.hdrStrings.push_back("Switching_From"); // append header string for field
fileDetails.hdrStrings.push_back("Switching_To"); // append header string for field

Expand All @@ -2830,6 +2834,7 @@ LogfileDetailsT Log::StandardLogFileDetails(const LOGFILE p_Logfile, const strin

if (p_Logfile == LOGFILE::BSE_SWITCH_LOG) { // BSE Switch Log
fileDetails.propertyTypes.push_back(TYPENAME::BOOL); // append property typename
fileDetails.stringTypes.push_back(STRING_QUALIFIER::FIXED_LENGTH); // append string type - default is fixed length
fileDetails.hdrStrings.push_back("Is_Merger"); // append header string for field
fileDetails.unitsStrings.push_back("-"); // append units string for field
fileDetails.typeStrings.push_back("BOOL"); // append type string for field
Expand All @@ -2846,6 +2851,7 @@ LogfileDetailsT Log::StandardLogFileDetails(const LOGFILE p_Logfile, const strin
if (p_Logfile != LOGFILE::BSE_SWITCH_LOG && p_Logfile != LOGFILE::SSE_SWITCH_LOG) { // BSE Switch Log or SSE Switch Log
// no - proceed
fileDetails.propertyTypes.push_back(TYPENAME::UINT); // append property typename
fileDetails.stringTypes.push_back(STRING_QUALIFIER::FIXED_LENGTH); // append string type - default is fixed length
fileDetails.hdrStrings.push_back("Record_Type"); // append header string for field
fileDetails.unitsStrings.push_back("-"); // append units string for field
fileDetails.typeStrings.push_back("INT"); // append type string for field - "INT" is good enough
Expand Down
6 changes: 5 additions & 1 deletion src/changelog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1694,6 +1694,10 @@
// - Updated the spin limit in 'BaseBinaryStar::CalculateDOmegaTidalDt()' to allow pseudo-synchronization based on Hut (1981), which affects the maximum spin with KAPIL2026 and ZAHN1977 options.
// - Added a limit to rotation change per time step in KAPIL2026 to ensure angular momentum conservation.
// - Updated dynamical tides equations in KAPIL2026 to match paper.
// 03.29.01 JR - March 15, 2026 - Defect repair:
// - Fix for issue 1441: vector out-of-bounds access in Log.cpp, which is known to cause COMPAS to terminate on at least one Linux
// distribution (Manjaro), possibly C++ version specific. See issue 1441 for description of defect and repair details.
//
//
// Version string format is MM.mm.rr, where
//
Expand All @@ -1704,7 +1708,7 @@
// if MM is incremented, set mm and rr to 00, even if defect repairs and minor enhancements were also made
// if mm is incremented, set rr to 00, even if defect repairs were also made

const std::string VERSION_STRING = "03.29.00";
const std::string VERSION_STRING = "03.29.01";


# endif // __changelog_h__
Loading