Allow None in simulator's input_state type#458
Open
thierry-martinez wants to merge 1 commit intoTeamGraphix:masterfrom
Open
Allow None in simulator's input_state type#458thierry-martinez wants to merge 1 commit intoTeamGraphix:masterfrom
None in simulator's input_state type#458thierry-martinez wants to merge 1 commit intoTeamGraphix:masterfrom
Conversation
The `run` method handles `None` and doesn't add input nodes to the
backend in this case, assuming that the backend has already been
prepared by the caller. However, the type annotation prevented using
`None` as an `input_state` value.
```python
if input_state is not None:
self.backend.add_nodes(self.pattern.input_nodes, input_state)
```
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
=======================================
Coverage 88.29% 88.29%
=======================================
Files 44 44
Lines 6533 6533
=======================================
Hits 5768 5768
Misses 765 765 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
runmethod handlesNoneand doesn't add input nodes to the backend in this case, assuming that the backend has already been prepared by the caller. However, the type annotation prevented usingNoneas aninput_statevalue.