Skip to content

Fix CI#19

Merged
EarlMilktea merged 9 commits intomasterfrom
fix-ci
Aug 10, 2025
Merged

Fix CI#19
EarlMilktea merged 9 commits intomasterfrom
fix-ci

Conversation

@EarlMilktea
Copy link
Collaborator

@EarlMilktea EarlMilktea commented Aug 8, 2025

Changes

  • Add --check to ruff format
  • Use uv correctly/aggressively
  • Run clippy for all targets

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.86%. Comparing base (62ff724) to head (1665ea4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   95.35%   94.86%   -0.49%     
==========================================
  Files          16       16              
  Lines         925      935      +10     
  Branches       27       27              
==========================================
+ Hits          882      887       +5     
- Misses         43       48       +5     
Flag Coverage Δ
python 100.00% <ø> (ø)
rust 92.46% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EarlMilktea EarlMilktea self-assigned this Aug 8, 2025
@EarlMilktea EarlMilktea requested a review from Copilot August 8, 2025 17:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates CI workflows to improve consistency and efficiency by standardizing on uv for Python package management and fixing various command syntax issues.

  • Replaced actions/setup-python + astral-sh/setup-uv with just astral-sh/setup-uv@v6 across all workflows
  • Added --check flag to ruff format and consolidated Python linting commands
  • Updated Rust commands to use correct syntax and run clippy on all targets

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/test_py.yml Simplified setup by using only uv action
.github/workflows/doc.yml Added concurrency control and migrated to uv for dependency management
.github/workflows/cov.yml Simplified setup by using only uv action
.github/workflows/check_rs.yml Fixed rustfmt syntax and enhanced clippy to check all targets
.github/workflows/check_py.yml Consolidated Python linting workflow and migrated to uv

@EarlMilktea EarlMilktea marked this pull request as ready for review August 8, 2025 17:36
Copy link
Contributor

@thierry-martinez thierry-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

Copy link
Contributor

@shinich1 shinich1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@EarlMilktea EarlMilktea merged commit cd5e8fa into master Aug 10, 2025
49 checks passed
@EarlMilktea EarlMilktea deleted the fix-ci branch August 10, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants