Significant Elevator Improvements#1520
Open
FireController1847 wants to merge 4 commits into
Open
Conversation
Author
|
I deployed the JAR and tested it on a live FTB Evolution server with my friends. So far, I have not encountered any issues. I will follow up with fixes or updates if anything comes up, but I do not anticipate any major problems. From my testing, this should be ready to merge. I did not include a version bump in this PR, so that will still need to be handled if you decide to merge it. |
desht
reviewed
Jun 21, 2026
| double syncedSpeedMult; // speed multiplier, calculated on server, sync'd to client | ||
| @DescSynced | ||
| public int multiElevatorCount; // number of elevator columns in the multiblock | ||
| @DescSynced |
Member
There was a problem hiding this comment.
Why make this @DescSynced ? I can't see where this is needed on the client outside GUI context?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1454