created a new settings page for the new UI#959
Closed
L-Tarun-Aditya wants to merge 18 commits intostagefrom
Closed
created a new settings page for the new UI#959L-Tarun-Aditya wants to merge 18 commits intostagefrom
L-Tarun-Aditya wants to merge 18 commits intostagefrom
Conversation
9eaf1bb to
305f129
Compare
2 tasks
2 tasks
65351f3 to
d315869
Compare
3c91ffe to
ed80ccc
Compare
L-Tarun-Aditya
commented
Mar 17, 2026
L-Tarun-Aditya
commented
Mar 17, 2026
11 tasks
Smayur0
reviewed
Mar 17, 2026
Smayur0
reviewed
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors account-related UI by moving profile/security functionality out of the dashboard into a new protected Settings route, and adds MFA flows (2FA setup/disable + MFA sign-in PIN).
Changes:
- Add
/settingsroute with a newUserSettingspage (sidebar tabs) and newProfileInfo+TwoFactorAuthcomponents. - Add MFA sign-in PIN component and update Sign In to branch into MFA when
mfaRequiredis returned. - Update theme/button styling by introducing
--white-fixedand adjusting several component CSS modules; remove some dashboard cards and delete Sign In/UserInfo tests.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui/src/utils/Constants.js | Reformat dashboard titles; add USER_SETTINGS_TITLE. |
| packages/ui/src/page/dashboard/Dashboard.jsx | Remove Plan/User Info/Password/Setting cards from dashboard. |
| packages/ui/src/index.css | Add --white-fixed theme token. |
| packages/ui/src/components/usersettings/UserSettings.module.css | New Settings page layout/styles. |
| packages/ui/src/components/usersettings/UserSettings.jsx | New Settings page with sidebar tabs. |
| packages/ui/src/components/userinfo/UserInfo.module.css | Adjust spacing + ensure primary button text uses --white-fixed. |
| packages/ui/src/components/twofactorauth/TwoFactorAuth.module.css | New 2FA UI styling. |
| packages/ui/src/components/twofactorauth/TwoFactorAuth.jsx | New 2FA enable/verify/disable flows using /auth/mfa/* endpoints. |
| packages/ui/src/components/settings/SettingCard.module.css | Ensure danger button text uses --white-fixed. |
| packages/ui/src/components/profileinfo/ProfileInfo.module.css | New profile/settings grid card layout styling. |
| packages/ui/src/components/profileinfo/ProfileInfo.jsx | New page composing UserInfo/ChangePassword/Setting/Plan. |
| packages/ui/src/components/pin/Pin.module.css | New MFA PIN input styling. |
| packages/ui/src/components/pin/Pin.jsx | New MFA PIN verification component (/auth/mfa/signin). |
| packages/ui/src/components/dropdown/UserDropDown.jsx | Add Settings link to dropdown. |
| packages/ui/src/components/currentplan/CurrentPlan.module.css | Update spacing and button text color variable. |
| packages/ui/src/components/currentplan/CurrentPlan.jsx | Set Button variant="primary" for upgrade button. |
| packages/ui/src/components/common/button/Button.module.css | Change disabled styling (remove opacity). |
| packages/ui/src/components/changepassword/ChangePassword.module.css | Ensure primary button text uses --white-fixed. |
| packages/ui/src/components/auth/Signin.jsx | Add MFA-required branch and render PIN UI; hide form while in MFA. |
| packages/ui/src/App.jsx | Add protected /settings route. |
| packages/ui/tests/components/UserInfo.test.jsx | Delete tests. |
| packages/ui/tests/components/auth/Signin.test.jsx | Delete tests. |
| packages/app/utils/constants.js | Formatting cleanup of message constants. |
Comments suppressed due to low confidence (1)
packages/ui/src/utils/Constants.js:648
USER_SETTINGS_TITLEis exported but appears to be unused (no references inpackages/ui/src). If it’s not needed, remove it; otherwise, wire it into the settings UI to avoid dead constants drifting out of sync.
export const DASHBOARD_CARDS_TITLE = ["Usage", "Generate New API Key"];
export const USER_SETTINGS_TITLE = [
"Plan",
"User Info",
"Change Password",
"Setting",
];
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
14
to
18
| .button:disabled { | ||
| color: var(--white); | ||
| cursor: not-allowed; | ||
| opacity: 0.8; | ||
| pointer-events: none; | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
86838f5 to
e72feab
Compare
11 tasks
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
this pr closes #958
Title
Implement Dedicated Settings Page & 2FA
Description
This PR introduces a dedicated Settings Page to centralize account management and improve security. It migrates existing account features from the Dashboard and adds Two-Factor Authentication (2FA) support.
Key Changes:
Why is this needed?
What type of PR is this? (Check all applicable)
Screenshots (if applicable)
mfa.mp4
Checklist