fix(#981): prevent multiple duplicate success toasts on guest login#996
Open
sidhanta03 wants to merge 2 commits intostagefrom
Open
fix(#981): prevent multiple duplicate success toasts on guest login#996sidhanta03 wants to merge 2 commits intostagefrom
sidhanta03 wants to merge 2 commits intostagefrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Resolves #981.
Rapidly clicking the "Sign in as Guest" button previously caused multiple identical API requests
and overlapping UI success toasts.
Changes made:
useRefto securely block rapid double/tripleclicks — mathematically impossible for 2 clicks to pass the guard since refs mutate synchronously
setIsSubmit(true)for visual UI feedback while request is pendingsetTimeoutcooldown inside thefinallyblock to prevent aggressive spamming onfast-resolving errors
try/finallypattern to ensure lock always releases on both success and failureWhat type of PR is this?
Checklist:
hard-to-understand areas