Merged
Conversation
Pull Request Test Coverage Report for Build 23170454240Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #98. That PR introduced support for generics, but only same-package generics would work. This one expands that to support generic types defined in different packages, and generic types using other custom types for type substitutions.
I had to bump the
golang.org/x/toolspackage to the newest version as it wouldn't work with Go 1.25. That update had some breaking changes, so I had to update some unrelated parts of the code as well.As a side-note, we also need to migrate this project to Go 1.26; I might open another PR for that tomorrow morning.