docs: add provider-leak review rule and ticket-writing guidance - #5
Closed
shivros wants to merge 1 commit into
Closed
docs: add provider-leak review rule and ticket-writing guidance#5shivros wants to merge 1 commit into
shivros wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two org-guidance updates stemming from the COD-437/PR-#36 provider leak review:
review.md — new blocking finding
Provider coupling. Providers are libraries, not routes: operation names, HTTP paths, core crates, and hardcoded source-string checks must never name a specific provider outside its own crate. Adding a provider = provider-crate dependency + one config entry. If adding a provider would touch core/server/cli/mcp, block and redesign.
org.md — new Ticket Writing section
POST /ingest, notPOST /ingest/herdr)Evidence: PR TechGodHQ/iris#36 shipped
ingest_herdrhardcoded into iris-mcp/iris-server/operations.yaml exactly because the ticket said/ingest/herdr. Refactor tracked in COD-453.