Skip to content

fix: preserve legacy Telegram token upgrades - #44

Merged
shivros merged 1 commit into
mainfrom
runner/COD-455-telegram-token-compat
Sep 5, 2026
Merged

fix: preserve legacy Telegram token upgrades#44
shivros merged 1 commit into
mainfrom
runner/COD-455-telegram-token-compat

Conversation

@shivros

@shivros shivros commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Preserve TELEGRAM_BOT_TOKEN as a deprecated, default-Telegram-only upgrade fallback when the canonical IRIS_TELEGRAM_BOT_TOKEN is absent.
  • Make canonical configuration authoritative, emit a secret-safe structured migration warning for fallback use, and cover environment precedence/containment.
  • Update Docker, Compose, and TOML documentation to teach the canonical variable and migration path.

Verification

  • cargo test -p iris-providers (104 passed)
  • cargo build --all-targets
  • cargo test --all-targets (217 passed)
  • cargo clippy --all-targets -- -D warnings
  • cargo fmt --all -- --check
  • cargo run -p iris-codegen --bin iris-codegen -- check
  • git diff --check

Closes COD-455.

@shivros

shivros commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Automated Review Panel

Reviewer A — GPT-5.6-terra

Finding fixed: the Docker quick-start passed the old host variable into the canonical container environment. Updated it to source ${IRIS_TELEGRAM_BOT_TOKEN} so new deployments are not taught the deprecated name.

Reviewer B — independent review

APPROVE. The fallback is restricted to the default Telegram instance; canonical precedence, secret-safe structured warning, tests, and documentation satisfy the ticket.

After the Reviewer A correction, the complete required verification suite passed again: provider tests (104), workspace tests (217), build, strict clippy, formatting, codegen freshness, and diff check. The known imap-proto future-incompatibility warning remains pre-existing.

@shivros

shivros commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Auto-Merge Gate approval

Confidence: 0.94

The implementation directly satisfies COD-455: it preserves legacy-only default Telegram startup, gives IRIS_TELEGRAM_BOT_TOKEN canonical precedence, confines the fallback to Telegram/default instance, emits a credential-safe structured warning, and updates all checked-in configuration guidance. The focused tests cover legacy-only, canonical-only, precedence, and non-Telegram containment.

Checks observed: CI Test, Format Check, Clippy, Secret Scan, Dependency Audit, and Creed context drift all completed successfully.

Scope limits: three files; configuration compatibility and documentation only. No unresolved reviews, manual-review marker, deployment cutover, or credential value exposure was found.

— Auto-Merge Gate

@shivros
shivros merged commit bea30a4 into main Sep 5, 2026
6 checks passed
@shivros
shivros deleted the runner/COD-455-telegram-token-compat branch September 5, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant