You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add deterministic public-router coverage for a configured HTTP bearer token
prove /providers rejects missing, malformed, and incorrect credentials, while accepting the configured test credential
prove /health remains available without credentials when the token boundary is enabled
Scope
Test-only follow-up for COD-469. Authentication policy, token storage, public operations, generated artifacts, deployment behavior, and runtime configuration are unchanged.
The test uses the public configured-token app constructor and Axum oneshot requests at the actual router boundary. Both independent review-panel seats approved the final diff.
APPROVE — The change meets COD-469. It builds a nonblank-token router through the public constructor and exercises /providers via oneshot for missing, malformed, incorrect, and exact bearer credentials; it also verifies unauthenticated /health remains 200. Assertions inspect only status codes, so the configured test credential is not emitted in logs, payloads, snapshots, or docs. No correctness or regression issue found.
Reviewer B — Gemini 3 Flash
APPROVE — The test exercises the full router boundary via oneshot, including configured middleware and the /health bypass. The no-op audit fixture correctly satisfies the public constructor's trait requirements. Coverage includes missing, malformed, and incorrect tokens, while using a test-only string and status-only assertions. The change is test-only and does not modify production authentication behavior.
Runner verification
cargo build --all-targets, cargo test --all-targets (221 tests), strict Clippy, format check, codegen freshness, and git diff --check all passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/providersrejects missing, malformed, and incorrect credentials, while accepting the configured test credential/healthremains available without credentials when the token boundary is enabledScope
Test-only follow-up for COD-469. Authentication policy, token storage, public operations, generated artifacts, deployment behavior, and runtime configuration are unchanged.
Verification
Review evidence
The test uses the public configured-token app constructor and Axum
oneshotrequests at the actual router boundary. Both independent review-panel seats approved the final diff.