Skip to content

feat: expose generated Rite CLI reads - #11

Merged
shivros merged 1 commit into
mainfrom
runner/COD-464-generated-cli-surface
Sep 6, 2026
Merged

feat: expose generated Rite CLI reads#11
shivros merged 1 commit into
mainfrom
runner/COD-464-generated-cli-surface

Conversation

@shivros

@shivros shivros commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expose the generated list-sources, list-handlers, and get-handler commands directly from rite-cli
  • route reads through the existing execute_operation dispatcher with JSON output/error contracts
  • preserve both explicit serve and no-subcommand server invocation; document CLI/MCP usage

Verification

  • cargo fmt --all -- --check
  • cargo build --all-targets
  • cargo test --all-targets
  • cargo clippy --all-targets -- -D warnings
  • CLI read, not-found, invalid-config JSON, and explicit/default serve smoke checks

Closes COD-464.

@shivros

shivros commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Automated Review Panel

Reviewer A — gpt-5.6-terra

Resolved finding: generated-read validation errors initially mixed timestamped diagnostics with JSON. Read-mode config validation now suppresses diagnostics and returns only deterministic {"error":"invalid Rite configuration"} with exit 1. Reviewer also verified workspace tests, Clippy, codegen check, generated command paths, and explicit/default serve behavior.

Reviewer B — independent review

APPROVE. Confirmed flattened GeneratedCommand keeps the generated API contract authoritative, read commands use the shared dispatcher, the placeholder secret is not emitted or used for webhook ingress, and global CLI arguments preserve server compatibility.

Both initial review findings (manual generated-command duplication and non-JSON setup errors) were addressed before this PR was opened.

@shivros
shivros marked this pull request as ready for review September 6, 2026 22:06
@shivros

shivros commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Auto-Merge Gate

Confidence: 0.93

The generated list-sources, list-handlers, and get-handler CLI reads are wired through Rite's existing execute_operation dispatcher, preserving the contract as the sole operation definition. The default and explicit serve paths remain compatible, with deterministic JSON output/error behavior documented.

Observed checks: GitHub Actions test completed successfully. Independent local verification also passed: cargo test --all-targets (14 tests).

Scope reviewed: four coherent files (CLI wiring, dependencies/lockfile, README); no deployment, credential, destructive, or manual-review scope was found.

@shivros
shivros merged commit 33f20b2 into main Sep 6, 2026
1 check passed
@shivros
shivros deleted the runner/COD-464-generated-cli-surface branch September 6, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant