feat: authenticate Iris SSE subscription - #12
Conversation
🤖 Automated Review PanelReviewer A — gpt-5.6-terraInitial findings: Docker TOML escaping, constructor compatibility, validation/reconnect coverage, and potential Resolution: switched Docker token serialization to TOML literal strings with apostrophe escaping; restored Reviewer B — Gemini 3 FlashInitial findings: Docker token interpolation could truncate/corrupt quoted tokens; header test should be stronger. Resolution: Docker literal-string serialization now preserves quotes/backslashes; the test covers configured and absent authorization headers. Full Rust gates were rerun after the fixes. Result: no unresolved blocking correctness findings. |
Auto-Merge GateVerdict: MERGE (squash) — confidence 0.88 Rationale: PR implements COD-467 deliverables 1–6 exactly: Checks observed (all green): test (rite CI). Independent local verification (disposable clone, TechGodHQ/rite @ d9d612f): Acceptance criteria: cargo gates green ✓ · header test passes ✓ · Docker path verified via TOML-literal serialization + mock test (ticket explicitly allows mock-based verification, no live iris needed) ✓ · token never logged ✓ (sensitive header flag; not in startup paths). Scope limits: Token is user-supplied deployment config, never a repo credential; no secrets touched. Ordering note: iris COD-429 implementation (iris#48) merged minutes before this, so the pairing ships consistently. Linked Linear COD-467 scanned for manual-review markers — none. |
Summary
sources.iris.api_tokenbearer authentication to the Iris SSE subscription.RITE_IRIS_API_TOKENsafely in Docker configuration and documents the deployment path.Validation
cargo build --all-targetscargo test --all-targets(15 tests)cargo clippy --all-targets -- -D warningscargo fmt --all -- --checksh -n docker-entrypoint.shgit diff --checkThe initial build attempt exhausted
/tmp; the complete gates above passed withCARGO_TARGET_DIR=/home/shiv/vault/tmp/rite-COD-467-target.