Skip to content

feat: add Rite pipeline observability (COD-433) - #8

Merged
shivros merged 1 commit into
mainfrom
runner/COD-433-observability
Aug 20, 2026
Merged

feat: add Rite pipeline observability (COD-433)#8
shivros merged 1 commit into
mainfrom
runner/COD-433-observability

Conversation

@shivros

@shivros shivros commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Implements COD-433 observability for Rite:

  • secret-free startup inventory for the listener, enabled sources, and handlers
  • terse structured logs for webhook and Iris SSE events, matches, and action outcomes
  • GET /status with event/action counters, uptime, and handler count

Verification

cargo test --all-targets
cargo clippy --all-targets -- -D warnings
cargo fmt --all -- --check

All passed locally.

Notes

events_matched counts events with one or more matching handlers; action counters retain per-handler outcome totals.

@shivros

shivros commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Automated Review Panel

GPT-5.6 (openai/gpt-5.5)

Initial review flagged three correctness/safety issues: events_matched was counting handlers rather than events; request-error logs could expose action URL secrets; and startup logs preceded configuration validation. All three were fixed before the final verification run. The reviewer confirmed the requested status fields and shared counter architecture otherwise aligned with COD-433.


Gemini 3 Flash (google/gemini-3-flash-preview)

Initial review flagged the same counter-semantics issue: one event matching two handlers must produce one matched-event count, not two. Fixed before final verification: events_matched increments once only when an event has at least one matching handler.

Final local verification after fixes: cargo test --all-targets, cargo clippy --all-targets -- -D warnings, and cargo fmt --all -- --check all passed.

@shivros
shivros marked this pull request as ready for review August 20, 2026 16:10
@shivros

shivros commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Auto-Merge Gate

Confidence: 0.91

COD-433 is a focused, goal-aligned observability change: secret-safe startup inventory, concise webhook/Iris event and handler outcome logs, and atomic process-local /status counters. The implementation includes the requested startup-summary and status-counter tests.

Checks observed: GitHub CI test passed; local cargo test --all-targets, cargo clippy --all-targets -- -D warnings, and cargo fmt --all -- --check passed on head 4c40907187bcfb900aadfec9d3bdc0f5b39b0bdb.

Scope limit: merge covers the code change only; it does not assert a live deployment or production event-flow verification.

@shivros
shivros merged commit 5e66194 into main Aug 20, 2026
1 check passed
@shivros
shivros deleted the runner/COD-433-observability branch August 20, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant