Meetecho update v1.4.1#10
Merged
Merged
Conversation
This fixes issue meetecho#3622. Changes made in commit fd24309 were missing a variable declaration and closing brace. These have been added.
…he rest of the codebase (meetecho#3608) * suspend_cond_mutex the same as every other mutex in janus_audiobridge.c (and elsewhere) * suspend_cond the same as in src/transports/janus_mqtt.c
This patch resolves several severe memory leaks in the MQTT transport:
1. Receive Path Properties Leak: Cleans up the `janus_mqtt_transaction_states`
hash table on terminal responses (success/error/ack) so MQTTProperties
structs are properly freed.
2. Send Path Properties Leak: Replaces `MQTTProperties_copy` with a shallow
copy to prevent double-allocation (Paho handles the deep copy internally).
3. String Duplication Leaks: Removes `g_strdup` and `g_strndup` on transaction
and correlationData strings during send, as Paho duplicates them internally.
4. Paho Queue Bug: Changes `ret = FALSE` to `ret = TRUE` in the message_arrived
callback so Paho doesn't infinitely queue unacknowledged messages in RAM.
5. Malformed JSON Leak: Adds `json_decref(root)` if the transaction string is
missing to prevent leaking the JSON object.
…eetecho#3636) Thanks to Haruto Kimura (Stella) for reporting this issues! * Fix underflow risk when using RTX * Fix OOB read/write risk when using VP8 simulcast * Fix heap over-read risk when opening datachannels * Put a cap to how large incoming RTP/RTCP packets can be (helps fixing potential stack buffer overflows when doing SRTP in SIP/NoSIP plugins, and possibly RTP forwarders in general) * Fix potential stack buffer overflow when processing craftes MJR file * Add NULL check to VideoRoom for janus_videoroom_session_get_publisher, where missing
…t) (meetecho#3637) Thanks to Kelvin Mbogo (Add Content) for reporting this issues! * Fix ACL matching in HTTP and WebSocket transport plugins * Fix extension matching and reject relative paths when creating file-based Streaming plugin mountpoints * Fix custom SIP headers by rejecting headers with CR/LF in their values
bencelaszlo
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
update techteamer fork with meetecho v.1.4.1
References:
YouTrack ticket(s):
FKITDEV-8745 Janus - sérülékenységeket javító patchek alkalmazása
Related PR(s):
nothing