ci [fkitdev-8416] improve github actions

.github/workflows/pull-request.yaml

@@ -0,0 +1,199 @@
+name: Pull Request
+
+on:
+  pull_request:
+
+concurrency:
+  group: pr-${{ github.event.pull_request.number }}
+  cancel-in-progress: true
+
+env:
+  NODE_VERSION: "24"
+
+defaults:
+  run:
+    shell: bash
+
+jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v6
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: yarn
+          cache-dependency-path: yarn.lock
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Lint
+        run: |
+          set -euo pipefail
+          yarn lint 2>&1 | tee lint-results.txt
+
+      - name: Upload lint results
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: lint-results
+          path: lint-results.txt
+
+  audit:
+    name: Audit
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v6
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: yarn
+          cache-dependency-path: yarn.lock
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Audit
+        run: |
+          set -euo pipefail
+
+          set +e
+          yarn audit --groups dependencies 2>&1 | tee audit-results.txt
+          set -e
+
+          yarn run improved-yarn-audit \
+            --min-severity critical \
+            2>&1 | tee -a audit-results.txt
+
+      - name: Upload audit results
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: audit-results
+          path: audit-results.txt
+
+  test:
+    name: Unit Tests
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    env:
+      NODE_ENV: ci
+
+    services:
+      rabbitmq:
+        image: rabbitmq:4.1.4
+        ports:
+          - 5672:5672
+          - 5671:5671
+        options: >-
+          --health-cmd "rabbitmq-diagnostics status"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v6
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: yarn
+          cache-dependency-path: yarn.lock
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Unit tests
+        run: |
+          set -euo pipefail
+          yarn test:ci 2>&1 | tee unit-test-results.txt
+
+      - name: Upload test results
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: unit-test-results
+          path: unit-test-results.txt
+
+      - name: Upload lcov coverage
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: jest-lcov
+          path: test/coverage/jest/lcov.info
+
+  sonar:
+    name: SonarQube Scan
+    runs-on: ubuntu-latest
+    needs: test
+    permissions:
+      contents: read
+    steps:
+      - uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+
+      - name: SonarQube Scan
+        uses: SonarSource/sonarqube-scan-action@v6
+        env:
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        with:
+          args: >
+            -Dsonar.organization=techteamer
+            -Dsonar.projectKey=TechTeamer_mq
+            -Dsonar.host.url=https://sonarcloud.io
+            -Dsonar.login=${{ secrets.SONAR_TOKEN }}
+            -Dsonar.pullrequest.key=${{ github.event.pull_request.number }}
+            -Dsonar.pullrequest.branch=${{ github.head_ref }}
+            -Dsonar.pullrequest.base=${{ github.base_ref }}
+            -Dsonar.scanner.metadataFilePath=${{ github.workspace }}/sonar-report-task.txt
+
+      - name: Upload Sonar report metadata
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: sonar-report-task
+          path: sonar-report-task.txt
+
+  build:
+    name: Build
+    runs-on: ubuntu-latest
+    needs: [lint, audit, test, sonar]
+    permissions:
+      contents: read
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v6
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: yarn
+          cache-dependency-path: yarn.lock
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+
+      - name: Build
+        run: |
+          set -euo pipefail
+          yarn build 2>&1 | tee build-results.txt
+
+      - name: Upload build results
+        if: always()
+        uses: actions/upload-artifact@v6
+        with:
+          name: build-results
+          path: build-results.txt

index.js

@@ -1,3 +1,4 @@
+/* eslint-disable n/no-missing-import */
 import QueueClient from './src/QueueClient.js'
 import QueueConfig from './src/QueueConfig.js'
 import QueueConnection from './src/QueueConnection.js'

package.json

@@ -27,8 +27,8 @@
     "build": "rm -fr dist/* && tsc -p tsconfig.json && tsc -p tsconfig-cjs.json && ./fixup.sh",
     "lint": "eslint . --max-warnings 0 --ignore-pattern \"test/*\" && echo 'npm run eslint --max-warnings 0'",
     "lint:fix": "eslint . --fix && eslint --max-warnings 0 .",
-    "unit": "vitest run",
-    "test": "yarn lint && c8 --temp-directory=./test/coverage/tmp vitest run && c8 report --reporter=text-lcov --report-dir=./test/coverage/ --reporter=lcovonly  | coveralls"
+    "test": "vitest run",
+    "test:ci": "c8 --temp-directory=./test/coverage/tmp vitest run && c8 report --reporter=text-lcov --report-dir=./test/coverage/ --reporter=lcovonly"
   },
   "type": "module",
   "dependencies": {
@@ -46,7 +46,6 @@
     "@semantic-release/release-notes-generator": "^14.0.0",
     "@types/amqplib": "^0.10.8",
     "c8": "^9.1.0",
-    "coveralls": "^3.1.1",
     "eslint": "^9.19.0",
     "eslint-config-standard": "^17.0.0",
     "eslint-plugin-import": "^2.31.0",
@@ -56,6 +55,7 @@
     "eslint-plugin-promise": "^7.2.1",
     "eslint-plugin-standard": "^5.0.0",
     "globals": "^15.14.0",
+    "improved-yarn-audit": "^3.0.4",
     "protobufjs": "^7.2.3",
     "seed-random": "^2.2.0",
     "semantic-release": "^24.0.0",

sonar-project.properties

@@ -1,5 +1,5 @@
 sonar.host.url=https://sonarcloud.io
-sonar.projectKey=techteamer_mq
+sonar.projectKey=TechTeamer_mq
 sonar.organization=techteamer
 
 sonar.sources=.

test/config/LoadConfig.ts

@@ -1,13 +1,13 @@
-let config
+let config;
 
-if (process.env.NODE_ENV === 'travis') {
-  config = (await import('./DefaultConfig')).default
+if (process.env.NODE_ENV === "ci") {
+  config = (await import("./TestConfig-ci")).default;
 } else {
   try {
-    config = (await import('./TestConfig')).default // eslint-disable-line n/no-missing-import
+    config = (await import("./TestConfig")).default; // eslint-disable-line n/no-missing-import
   } catch (testConfigLoadError) {
-    console.error('Cannot load test configuration', testConfigLoadError)
+    console.error("Cannot load test configuration", testConfigLoadError);
   }
 }
 
-export default config
+export default config;

test/config/TestConfig-ci.ts

@@ -0,0 +1,12 @@
+import QueueConfig from "../../src/QueueConfig";
+import ConsoleInspector from "../consoleInspector";
+
+export default new QueueConfig({
+  url: "amqp://guest:guest@localhost:5672",
+  options: {
+    rejectUnauthorized: false,
+  },
+  rpcTimeoutMs: 10000,
+  rpcQueueMaxSize: 100,
+  logger: new ConsoleInspector(console) as unknown as Console,
+});

test/config/TestConfig.ts

@@ -0,0 +1,17 @@
+import QueueConfig from "../../src/QueueConfig";
+import ConsoleInspector from "../consoleInspector";
+
+const certPath = "/workspace/vuer_docker/workspace/cert/vuer_mq_cert";
+
+export default new QueueConfig({
+  url: "amqps://localhost:5671",
+  options: {
+    rejectUnauthorized: false,
+    cert: certPath + "/client/cert.pem",
+    key: certPath + "/client/key.pem",
+    ca: [certPath + "/ca/cacert.pem"],
+  },
+  rpcTimeoutMs: 10000,
+  rpcQueueMaxSize: 100,
+  logger: new ConsoleInspector(console) as unknown as Console,
+});