fix: widen file_size_bytes to BigInteger (int4 -> bigint)#104
Merged
Conversation
MediaFile.file_size_bytes and CommentAttachment.file_size_bytes were INTEGER (int4, ~2.1GB ceiling), so files >2GB could not be recorded — undermining #64 (unlimited per-file uploads) and #98 (instance storage accounting). Migrate both columns to BigInteger with an alembic migration. Structural tests added.
… EXCLUSIVE) (review #99)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen
MediaFile.file_size_bytesandCommentAttachment.file_size_bytesfromInteger(int4, ~2.1 GB ceiling) toBigInteger, so files larger than ~2.1 GB can be recorded (media files support 10 GB+). Includes the AlembicALTER COLUMNmigration (with a lock/downtime note) + structural tests.Verification
CHANGELOG entry under
[Unreleased].