TD-4916 nhsuk override consolidation#3287
Merged
frank-hee merged 9 commits intoJun 23, 2025
Merged
Conversation
kevwhitt-hee
requested changes
Jun 9, 2025
Contributor
kevwhitt-hee
left a comment
There was a problem hiding this comment.
There are a few changes included in this PR that shouldn't be there, I believe. Please could this be addressed?
Contributor
There was a problem hiding this comment.
This file shouldn't be deleted.
Contributor
|
@frank-hee give me a nudge when the above has been addressed, and I'll pull your branch and test. |
kevwhitt-hee
approved these changes
Jun 23, 2025
Contributor
kevwhitt-hee
left a comment
There was a problem hiding this comment.
Looks good. Built branch, worked through application screens in mobile and desktop and saw no styling issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link
TD-4916
Description
.nhsuk items moved from index.scss and layout.scss into nhsuk.scss
_layout.cshtml headers updated to reflect current design system and remove need for several overrides
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: