TD-3223 Showing console '404' error when removing the delegate from activity and clicking browser back button#3305
Merged
Conversation
…ctivity and clicking browser back button
…ctivity and clicking browser back button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link
https://hee-tis.atlassian.net/browse/TD-3223
Description
I replaced the direct check for a null progress object and HTTP 410 Gone status code response with a conditional that also verifies whether the delegate still has current progress for the given progressId. If not, it redirects to a StatusCode action in the LearningSolutions controller with a 410 code parameter
I updated the test method Delegate_removal_for_delegate_with_no_active_progress_returns_not_found_result to reflect the new behavior, where the action now redirects to a 410 status code page instead of returning a NotFoundResult
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: