Skip to content

TD-6954 selection and deselection is not working #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sherif-olaboye wants to merge 4 commits into
base: DLS-Release-v1.3.1
Choose a base branch
from
Open

TD-6954 selection and deselection is not working #3595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e0444c
TD-6954 selection and deselection is not working
sherif-olaboye May 28, 2026
978bc65
TD-6954 fixing the PR error
sherif-olaboye May 28, 2026
bd4ac96
TD-6954 fixing the PR error
sherif-olaboye May 28, 2026
c39ff30
TD-6954 Return the comment in the code
sherif-olaboye Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions DigitalLearningSolutions.Web/Scripts/frameworks/selectoptionalcompetencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,31 @@
const groups = document.querySelectorAll<HTMLDivElement>('.nhsuk-checkboxes');

groups.forEach((group) => {
const groupToggle = group.querySelector<HTMLInputElement>('input[name="GroupIds"]');
if (!groupToggle) return;
Copy link
Copy Markdown
Contributor

@kevwhitt-hee kevwhitt-hee Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have we removed this? it seems like a sensible quite error catch?

Copy link
Copy Markdown
Contributor

@kevwhitt-hee kevwhitt-hee Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see it has moved to line 13


const groupToggle =
group.querySelector<HTMLInputElement>('input[name="GroupIds"]');
// All individual competency checkboxes in the group
Copy link
Copy Markdown
Contributor

@kevwhitt-hee kevwhitt-hee Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than removing code comments, it would be useful to update them to explain what is changing

Copy link
Copy Markdown
Contributor Author

@sherif-olaboye sherif-olaboye Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done the comment has been re-added

const childCheckboxes = group.querySelectorAll<HTMLInputElement>(
'input[name="SelectedCompetencyIds"]',
);
const childCheckboxes =
group.querySelectorAll<HTMLInputElement>(
'input[name="SelectedCompetencyIds"]',
);

const updateState = () => {
const isChecked = groupToggle.checked;
if (!groupToggle) {
return;
}

childCheckboxes.forEach((_, index) => {
childCheckboxes[index].checked = isChecked;
const setChildrenCheckedState = (checked: boolean) => {
childCheckboxes.forEach((checkboxElement) => {
const checkbox = checkboxElement;
checkbox.checked = checked;
});
};

// Run when the group checkbox changes
groupToggle.addEventListener('change', updateState);
if (groupToggle.checked) {
setChildrenCheckedState(true);
}

// Also run at page load in case some are pre-checked server-side
updateState();
groupToggle.addEventListener('change', () => {
setChildrenCheckedState(groupToggle.checked);
});
});
});
6 changes: 5 additions & 1 deletion DigitalLearningSolutions.Web/Views/CompetencyAssessments/SelectOptionalCompetencies.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,11 @@
@foreach (var competency in competencyGroup)
{
<div class="nhsuk-checkboxes__item">
<input class="nhsuk-checkboxes__input" data-group="@competencyGroup.Key" id="competency-check-@competency.StructureId" name="SelectedCompetencyIds" checked="@(Model.SelectedCompetencyIds != null ? Model.SelectedCompetencyIds.Contains((int)competency.CompetencyID) : false)" type="checkbox" value="@competency.StructureId">
<input class="nhsuk-checkboxes__input"
data-group="@competencyGroup.Key"
id="competency-check-@competency.StructureId"
name="SelectedCompetencyIds"
checked="@(competencyGroup.Any(x => x.GroupOptionalCompetencies) || competency.Optional ? "checked" : null)"type="checkbox" value="@competency.StructureId">
<label class="nhsuk-label nhsuk-checkboxes__label" for="competency-check-@competency.StructureId">
@foreach (var flag in competency.CompetencyFlags)
{
Expand Down
Loading