Skip to content

TD-7112 Remove the Log in button in DLS #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevwhitt-hee merged 1 commit into from
Jun 3, 2026
+12 −3
Merged

TD-7112 Remove the Log in button in DLS #3600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions DigitalLearningSolutions.Data/Extensions/ConfigurationExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ public static class ConfigurationExtensions
private const string LearningHubOpenApiKey = "LearningHubOpenAPIKey";
private const string LearningHubOpenApiBaseUrl = "LearningHubOpenAPIBaseUrl";
private const string PricingPageEnabled = "FeatureManagement:PricingPage";

private const string ShowDlsLoginButton = "FeatureManagement:ShowDlsLoginButton";

private const string LearningHubAuthBaseUrl = "BaseUrl";
private const string LearningHubAuthLoginEndpoint = "LoginEndpoint";
private const string LearningHubAuthLinkingEndpoint = "LinkingEndpoint";
Expand Down Expand Up @@ -118,7 +119,11 @@ public static bool IsPricingPageEnabled(this IConfiguration config)
bool.TryParse(config[PricingPageEnabled], out bool isEnabled);
return isEnabled;
}

public static bool IsDlsLoginButtonShown(this IConfiguration config)
{
bool.TryParse(config[ShowDlsLoginButton], out bool isEnabled);
return isEnabled;
}
public static int GetLearningHubSsoHashTolerance(this IConfiguration config)
{
int.TryParse(config[$"{LearningHubSsoSectionKey}:{LearningHubSsoToleranceKey}"], out int ssoHashTolerance);
Expand Down
3 changes: 3 additions & 0 deletions DigitalLearningSolutions.Web/Views/Shared/_NavMenuItems.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,14 @@
}
else
{
@if (Configuration.IsDlsLoginButtonShown())
{
<li class="nhsuk-header__navigation-item @Html.GetSelectedCssClassIfTabSelected(NavMenuTab.LogIn)">
<a class="nhsuk-header__navigation-link" asp-controller="Login" asp-action="Index">
Log in
</a>
</li>
}
<li class="nhsuk-header__navigation-item @Html.GetSelectedCssClassIfTabSelected(NavMenuTab.Register)">
<a class="nhsuk-header__navigation-link" asp-controller="Register" asp-action="Start">
Register
Expand Down
3 changes: 2 additions & 1 deletion DigitalLearningSolutions.Web/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"PricingPage": true,
"ShowSelfAssessmentProgressButtons": false,
"LoginWithLearningHub": true,
"TableauSelfAssessmentDashboards": true
"TableauSelfAssessmentDashboards": true,
"ShowDlsLoginButton": false
},
"LearningHubOpenAPIBaseUrl": "https://uks-learninghubnhsuk-openapi-test.azurewebsites.net",
"LearningHubOpenAPIKey": "",
Expand Down
Loading