TD-5638- Removed custom administrator roles - replaced "Educator/Manager" and "Assessor" with "Supervisor" and "Nominated Supervisor"

[Auldrin-Possa]

JIRA link

TD-5638

Description

Summary

The initial implementation and major code changes were completed using Codex. Subsequent updates were made to align the implementation with the final task requirements.

Database Changes

A migration script has been added to perform the following actions:

• Drop the existing constraint on the CandidateAssessmentSupervisors table.

• Drop the SelfAssessmentSupervisorRoles table.

• Remove the SelfAssessmentSupervisorRoleID column from the CandidateAssessmentSupervisors table.

• Remove duplicate records from the CandidateAssessmentSupervisors table.

  • Prior to deleting duplicate records, all related references in the CandidateAssessmentSupervisorVerifications and SelfAssessmentResultSupervisorVerifications tables are updated to point to the retained CandidateAssessmentSupervisors record. This ensures referential integrity and allows obsolete duplicate records to be safely removed.

• Create a unique key constraint on the CandidateAssessmentSupervisors table.

Stored Procedure Updates

The following stored procedures have been updated to remove dependencies on the SelfAssessmentSupervisorRoles table:

• GetAssessmentResultsByDelegate
• GetCandidateAssessmentResultsById

Application Changes

Application code has been updated throughout the solution to remove all references to the SelfAssessmentSupervisorRoles table and align with the revised database schema.

Cleanup of Unused Resources

The following unused resources were removed as part of this change:

Service Methods

• GetSupervisorRolesForSelfAssessment
• GetSupervisorRolesBySelfAssessmentIdForSupervisor
• GetDelegateNominatableSupervisorRolesForSelfAssessment
• GetSupervisorRoleById

Controller Action Methods

• SetSupervisorRole
• EnrolDelegateSupervisorRole

Views/Forms

• EnrolDelegateSupervisorRole.cshtml
• SelectDelegateSupervisorRole.cshtml

Screenshots

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
• Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
• Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
• Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
• Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
  Either:
• Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • doc_1_here
    Or:
• Confirmed that none of the work that I have undertaken requires any updates to documentation