Develop/fixes/td 6925 fix sql server incompatability issuesv9.1.5#2
Merged
ColinBeebyHEE merged 3 commits intoMar 13, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the changes which were originally made to a v8.18.1 tag of the code. This is the same code changes no applied to a 9.1.5 tag of the code.
Summary:
Add SQL Server-compatible JSON handling (OPENJSON / JSON_VALUE / JSON_QUERY / FOR JSON PATH) and ensure sqlsrv is accepted as an alias for mssql-type branches. This brings parity with existing Postgres and MySQL implementations so the plugin can be used on Microsoft SQL Server deployments.
Why:
Existing code provided DB-specific JSON handling for Postgres and MySQL/MariaDB; SQL Server lacked equivalents. Adding SQL Server branches ensures functionality (JSON extraction, array expansion, aggregations) works correctly on MSSQL-based Moodle installations.
Implementation notes / decisions:
Used SQL Server native JSON functions: OPENJSON (array expansion), JSON_VALUE (scalar extraction), JSON_QUERY (for objects/arrays when needed), and FOR JSON PATH for aggregation.
Applied explicit casts for numeric types (INT/FLOAT) to match expected types used elsewhere.
Kept original Postgres and MySQL branches untouched to avoid regressions.
Added sqlsrv as a switch alias where mssql was used; for Moodle-native DB families the code uses mssql_native_moodle_database / sqlsrv_native_moodle_database cases where appropriate.