This repository was archived by the owner on Sep 18, 2025. It is now read-only.
Create InsetText View, ViewComponent and Model#49
Merged
akdalin-hee merged 2 commits intoApr 24, 2025
Conversation
Author
|
Different from the DLS version, I've added a default value for the cssClass variable as it would otherwise require at each initialisation. |
| { | ||
| public IViewComponentResult Invoke( | ||
| string text, | ||
| string cssClass = null |
There was a problem hiding this comment.
Why are we including this parameter? Do we ever alter the class of an inset text div?
| public class InsetTextViewComponent : ViewComponent | ||
| { | ||
| public IViewComponentResult Invoke( | ||
| string text, |
There was a problem hiding this comment.
would it be better to name this as contentHtml if we are rendering it as HTML below - @Html.Raw(Model.Text) ?
kevwhitt-hee
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create InsetText View, ViewComponent and Model
Screenshots
Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.

Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: