This repository was archived by the owner on Sep 18, 2025. It is now read-only.
Create Tabs View, ViewComponent and Model#51
Merged
Conversation
Author
|
This one is built on top of the Table view component |
kevwhitt-hee
left a comment
There was a problem hiding this comment.
I think that the inclusion of a table in the tab is just for illustration purposes in the NHSUK frontend components page. I think the tabs can contain anything.
Other than passing the name of a partial and its model, I don't think we could parameterise the content of the tab very well in a view component.
@paulstevendev what do you think?
6f81dbd to
f1fcf46
Compare
kevwhitt-hee
suggested changes
Apr 23, 2025
kevwhitt-hee
left a comment
There was a problem hiding this comment.
This looks good but I'm unsure why the TableViewComponent files are part of the PR, now?
…any ViewComponents, HTML and Partials as input input and render them as plain html
kevwhitt-hee
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create Tabs View, ViewComponent and Model
Screenshots
Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.

Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: