Skip to content
This repository was archived by the owner on Sep 18, 2025. It is now read-only.

Create Tabs View, ViewComponent and Model#51

Merged
akdalin-hee merged 5 commits into
mainfrom
feature/TD-5213-Create-tabs-view-component
May 1, 2025
Merged

Create Tabs View, ViewComponent and Model#51
akdalin-hee merged 5 commits into
mainfrom
feature/TD-5213-Create-tabs-view-component

Conversation

@akdalin-hee
Copy link
Copy Markdown

Description

Create Tabs View, ViewComponent and Model

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation
  • CHANGELOG entry

@akdalin-hee
Copy link
Copy Markdown
Author

This one is built on top of the Table view component

Copy link
Copy Markdown

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the inclusion of a table in the tab is just for illustration purposes in the NHSUK frontend components page. I think the tabs can contain anything.

Other than passing the name of a partial and its model, I don't think we could parameterise the content of the tab very well in a view component.

@paulstevendev what do you think?

@akdalin-hee akdalin-hee force-pushed the feature/TD-5213-Create-tabs-view-component branch from 6f81dbd to f1fcf46 Compare April 16, 2025 17:06
Copy link
Copy Markdown

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I'm unsure why the TableViewComponent files are part of the PR, now?

@akdalin-hee akdalin-hee merged commit 03e0a0a into main May 1, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants