This repository was archived by the owner on Sep 18, 2025. It is now read-only.
Replace URLs with ASP attributes where necessary. Add XML documentation. Minor corrections.#53
Merged
akdalin-hee merged 1 commit intoJun 3, 2025
Conversation
…on. Minor corrections.
kevwhitt-hee
reviewed
May 8, 2025
kevwhitt-hee
left a comment
kevwhitt-hee
left a comment
There was a problem hiding this comment.
These look good to me, Dalin. We seem to have removed some documentation as well as adding some. Was this deliberate? Can we add a note to the PR description explaining why, if so, please?
| /// <param name="aspAction">The asp-action to dynamically set the action path of the link..</param> | ||
| /// <param name="aspRouteData">The asp-all-route-data to dynamically set the extra parameters to the path of the link.</param> | ||
| /// <param name="url">The url for the link.</param> | ||
| /// <param name="style">The style attributes for the button.</param><param name="style">The style attributes for the button.</param> |
There was a problem hiding this comment.
Have we deliberately removed these, Dalin?
Author
There was a problem hiding this comment.
Yes, it was in order to remove duplication in the XML documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace URLs with ASP attributes where necessary. Add XML documentation where missing and remove duplicate documentation from ViewComponents relative to their ViewModel. Minor corrections.
Screenshots
Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: