This repository was archived by the owner on Sep 18, 2025. It is now read-only.
Create Fieldset View, ViewComponent and Model#56
Merged
Conversation
kevwhitt-hee
reviewed
Jun 3, 2025
| { | ||
| public FieldViewModel(Func<object, IHtmlContent> content) | ||
| { | ||
| Content = content; |
There was a problem hiding this comment.
I might be misunderstanding this, @akdalin-hee, so bear with me. Is this expecting raw html to be passed in for each field in the fieldset? If so, it probably doesn't make much sense to include Fieldset as a component. Fieldsets are pretty thin on markup but have complex child components, so we might want to leave them out of the view component library?
kevwhitt-hee
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create Fieldset View, ViewComponent and Model
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: