Skip to content
This repository was archived by the owner on Sep 18, 2025. It is now read-only.

Create Fieldset View, ViewComponent and Model#56

Merged
akdalin-hee merged 1 commit into
mainfrom
feature/TD-5200-Create-fieldset-view-component
Jun 3, 2025
Merged

Create Fieldset View, ViewComponent and Model#56
akdalin-hee merged 1 commit into
mainfrom
feature/TD-5200-Create-fieldset-view-component

Conversation

@akdalin-hee
Copy link
Copy Markdown

Description

Create Fieldset View, ViewComponent and Model

Screenshots

Screenshot 2025-06-02 092241


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation
  • CHANGELOG entry

@akdalin-hee akdalin-hee self-assigned this Jun 2, 2025
Copy link
Copy Markdown

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline question.

{
public FieldViewModel(Func<object, IHtmlContent> content)
{
Content = content;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be misunderstanding this, @akdalin-hee, so bear with me. Is this expecting raw html to be passed in for each field in the fieldset? If so, it probably doesn't make much sense to include Fieldset as a component. Fieldsets are pretty thin on markup but have complex child components, so we might want to leave them out of the view component library?

@kevwhitt-hee kevwhitt-hee self-requested a review June 3, 2025 07:53
@akdalin-hee akdalin-hee merged commit 3d7f33e into main Jun 3, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants