Skip to content

Remove temporary effect-rstest patch after upstream fixes merge #507

Description

@BleedingDev

Goal

Replace the temporary effect-rstest dependency patch with the upstream release or immutable canary containing ScriptedAlchemy/effect-rstest PR #4 — Effect equality and scoped test lifetimes, once that contribution is merged and its package is published.

This follows the direct-dependency adoption in TechsioCZ/ontos PR #501 — Native Effect Rstest migration. The temporary baseline is the immutable upstream package:

https://pkg.pr.new/ScriptedAlchemy/effect-rstest@79abbf684c7b150ee5f32694129a7caf969903bc

The temporary patch carries only upstream PR #4's generic adapter corrections: Effect equality, synchronous schema properties, discarded Effect success values, timed-out test settlement, and shared-layer setup interruption before scope closure. It must not become a permanent fork or compatibility shim.

Completion checklist

  • Confirm upstream PR Ticketing: Mandatory property validation #4 is merged and the replacement package actually contains its fixes.
  • Pin the released version or immutable merged-commit canary in every consuming workspace manifest.
  • Remove the effect-rstest entry from patchedDependencies and delete its patch file.
  • Regenerate pnpm-lock.yaml; verify a frozen install succeeds without the patch.
  • Verify no @app/effect-rstest alias or vendored implementation is restored.
  • Run typecheck, lint and lint-rule regressions, unit/component, tooling/generation, and service integration tests with N−1 worker defaults; retain zero browser retries.
  • Verify equality, schema-property and timeout/finalizer behavior against the actual installed package.

Keep this separate from unrelated dependency upgrades and cleanup work. The upstream CI and canary workflows initially required maintainer approval; a merged PR alone is not proof that a usable package has been published.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions