Fix intermittent Node proxy startup timeout in CI - #36
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python 3.12 job in main run 34576997760 timed out waiting five seconds for the Node OpenRouter proxy to listen. The subsequent main run passed without changes to the proxy or its test, consistent with intermittent startup latency.
Give the smoke-test readiness helper a 30-second monotonic deadline. It still returns immediately when the port opens and reports subprocess exits immediately. Timeout errors now include the wait budget. Regression tests cover startup after six seconds, a bounded timeout, and early process failure; production proxy behavior is unchanged.
Validation: the delayed-start regression fails with the old helper and passes with the fix; both real Node proxy smokes pass; 749 non-integration tests pass; Ruff, mypy, lock validation, and git diff --check pass. The latest existing main run also passes all Python, package, Docker, and integration jobs.