Skip to content

data: catch the assistant replies that survived the v2.4.1 cleaning - #232

Merged
ajamous merged 1 commit into
mainfrom
followup/dataset-markers
Sep 18, 2026
Merged

ajamous merged 1 commit into
mainfrom
followup/dataset-markers

Conversation

@ajamous

@ajamous ajamous commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #195, as promised there.

The translation step left model replies in the corpus in place of messages: "Maaf, saya tidak dapat membuka tautan...", "No tiene sentido en ningún idioma", "I'm sorry, but the text you provided is not clear". The v2.4.1 marker list caught 80 of them. This extends the list with the Indonesian, Spanish, Italian, French, German, Russian and Arabic phrasings and removes 335 more rows (138,003 to 137,668). Phrases were chosen to be specific enough not to match real SMS wording; a random sample of the removed rows is in the commit.

Also makes clean_ots_dataset.py write LF line endings, matching the committed file, so regenerating the dataset is byte-identical. test_clean_dataset.py passes (3/3).

The translation step left model replies in the corpus in place of messages
("Maaf, saya tidak dapat membuka tautan...", "No tiene sentido en ningún idioma",
"I'm sorry, but the text you provided is not clear"). The marker list caught 80;
this extends it with the Indonesian, Spanish, Italian, French, German, Russian
and Arabic phrasings and removes 335 more rows (138,003 -> 137,668). Phrases are
kept specific enough not to match real SMS wording.

The writer now emits LF line endings, matching the committed file, so
regenerating the dataset produces a byte-identical result.

Follow-up to #195.
@ajamous
ajamous merged commit 31770a5 into main Sep 18, 2026
3 checks passed
@ajamous
ajamous deleted the followup/dataset-markers branch September 18, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant