ci: run the offline SMPP suites - #233
Merged
Merged
Conversation
tests.yml only watched src/api_interface, so the 137 offline SMPP assertions (message_utils and the encoding round-trip) never ran in CI. Add a Node job that runs `npm test` in src/smpp_interface, and trigger the workflow on changes under src/smpp_interface as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests.ymlonly watchedsrc/api_interface/, so the 137 offline SMPP assertions (test_message_utils.jsandtest_encoding_roundtrip.js) never ran in CI, even though they cover the classification policy settings shipped in v2.11.0.This adds a Node 20 job that runs
npm testinsrc/smpp_interface(no API, upstream or proxy needed), and triggers the workflow on changes undersrc/smpp_interface/too. The job's own run on this PR is the proof it works.