feat(ical): allow revenue_manager to read a feed's imported blocks - #324
Open
modernitconsultants wants to merge 1 commit into
Open
feat(ical): allow revenue_manager to read a feed's imported blocks#324modernitconsultants wants to merge 1 commit into
modernitconsultants wants to merge 1 commit into
Conversation
TelivityAI#318 relaxed listing, reading and syncing feeds to revenue_manager, but GET /ical/feeds/:id/blocks was missed, so an integration can list the feeds and sync them while being unable to see what they imported. Reading the blocks is no more privileged than reading the feed beside it — they are the busy dates a sync just fetched, not credentials. Without it any consumer that reconciles imported availability against its own calendar has to hold admin purely to read. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#318relaxed listing, reading and syncing iCal feeds torevenue_manager, butGET /ical/feeds/:id/blockswas missed — so an integration can list the feeds and trigger a sync, and then cannot see what that sync imported.Reading the blocks is no more privileged than reading the feed beside it: they're the busy dates a sync just fetched, not credentials. Without this, any consumer that reconciles imported channel availability against its own calendar has to hold
adminpurely to read.One line, same role list as its neighbours.