fix(front-desk): the tape chart hides guests who are already in-house - #325
Open
modernitconsultants wants to merge 1 commit into
Open
Conversation
The fortnight view queried arrivalDateFrom / arrivalDateTo, which asks "who arrives during this window". That silently omits every guest who arrived before it and is still in the hotel — on a tape chart, the people most likely to be looked up. A guest who checked in yesterday for a week vanishes from today's view. A stay overlaps the window when it arrives before the window ends AND departs after it starts, so the filter becomes arrivalDateTo + departureDateFrom. Both are already accepted by ListReservationsDto; only the dashboard was asking the narrower question. Nothing else changes: same endpoint, same window, same rendering. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fortnight view queries
arrivalDateFrom/arrivalDateTo, which asks who arrives during this window. That silently omits every guest who arrived before it and is still in the hotel — on a tape chart, the people most likely to be looked up.A guest who checked in yesterday for a week disappears from today's view. Nothing errors; the row is simply absent.
A stay overlaps the window when it arrives before the window ends and departs after it starts, so the filter becomes
arrivalDateTo+departureDateFrom. Both are already accepted byListReservationsDto— only the dashboard was asking the narrower question.Same endpoint, same window, same rendering; one filter corrected.