Skip to content

Conversation

@godky
Copy link
Contributor

@godky godky commented Dec 8, 2025

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

Currently, the value of index obtained directly in webRender is always undefined, causing inserted elements to always be placed at the end of the parent container, which is incorrect in v-if scenarios(vue-next).

Reproduce link.

@godky godky requested a review from zealotchen0 as a code owner December 8, 2025 11:01
@github-actions github-actions bot added driver: js size: xs Denotes a PR that changes 0-9 lines labels Dec 8, 2025
@hippy-service
Copy link

hippy-service bot commented Dec 8, 2025

Hi, @godky. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Dec 8, 2025

After a quick scan, I have approved workflow to run.

Details

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@godky godky changed the title fix(web): Add index property in hippy-element fix(vue-next): Add index property in hippy-element Dec 8, 2025
@github-actions github-actions bot added size: s Denotes a PR that changes 10-99 lines and removed size: xs Denotes a PR that changes 0-9 lines labels Dec 16, 2025
@godky godky changed the title fix(vue-next): Add index property in hippy-element fix(web): correct node update ordering in web renderer Dec 16, 2025
@godky godky marked this pull request as draft December 16, 2025 04:12
@godky godky marked this pull request as ready for review December 16, 2025 07:19
@godky
Copy link
Contributor Author

godky commented Dec 18, 2025

Reproduce link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

driver: js size: s Denotes a PR that changes 10-99 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant