ci: run desktop packaging on PRs (macOS + Windows) - #469
Merged
jubaoliang merged 3 commits intoAug 29, 2026
Conversation
…atform selection - Adjusted the GitHub Actions workflow to trigger builds for pull requests affecting the `desktop/` directory, limiting them to `darwin-arm64` and `darwin-amd64` platforms only. - Enhanced platform selection logic to differentiate between pull request and tag dispatch events, ensuring appropriate builds are executed based on the event type. - Updated README to reflect changes in CI behavior and clarify build processes for different scenarios.
- Introduced a new job to dynamically select platforms based on the event type, allowing for more flexible builds. - Updated the matrix configuration to utilize the output from the platform selection step, streamlining the build process. - Removed redundant build decision steps, simplifying the workflow and improving clarity.
PR packaging should cover all macOS and Windows arches; keep Linux for tags/dispatch only. Co-authored-by: Cursor <cursoragent@cursor.com>
liukewia
changed the title
liukewia
marked this pull request as draft
August 28, 2026 09:08
liukewia
marked this pull request as ready for review
August 28, 2026 09:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requesttrigger fordesktop/**and the desktop workflow so PRs can smoke-test packaging without waiting for av*tag.darwin-arm64/darwin-amd64/windows-amd64/windows-arm64runners, instead of spinning up the full six-platform matrix (Linux stays on tags / dispatch).workflow_dispatch(platforms=all) on all six platforms, and document that split indesktop/README.md.Target branch
develop(feature / fix — default)main(release/*orhotfix/*only)Type of change
Test plan
Workflow YAML + README only.
select-platformsemits a JSON matrix:pull_request→ darwin-* + windows-*; dispatch honorsplatforms; otherwise all six.make allpasses locallyChecklist
CHANGELOG.md(if user-facing)