fix(tools): harden scope enforcement, credential storage, and subproc… - #15
Open
vpadival wants to merge 1 commit into
Open
fix(tools): harden scope enforcement, credential storage, and subproc…#15vpadival wants to merge 1 commit into
vpadival wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, Tyler! I found a handful of security and reliability issues while going through
the codebase. Here's what this PR addresses:
Filter_live_targets_httpx: fallback was returning the full unverified
target list instead of
[], causing noisy downstream scansRun_feroxbuster_tool:
feroxbuster_out.jsonwas deleted at the startof each loop iteration, so a crash on target N would wipe target N-1's findings.
Moved deletion outside the loop.
Scope bypass: An empty scope list was allowing all targets through.
Added an early return of
[]when scope is empty (L57–61)Plaintext credentials- credentials were being logged to SQLite
in plaintext. Added hashing before storage (L195–206)
WPScan token in argv- API token was visible in process arguments.
Moved to environment variable instead (~L408)
SSL verify disabled-
urllib.request.urlopenwas called with noSSL verification. Added proper SSL context (~L472)
Scope suffix logic- subdomain suffix matching was too permissive,
allowing unintended targets through. Tightened the match logic (L54–67)
Subfinder timeout (Informational)- subprocess had no timeout, risking
indefinite hangs. Added a reasonable timeout (~L238)
Happy to adjust anything if needed!
(Pls check if I made the same mistake of removing ur previous PRs last time😅)