Fix three launch blockers: Homebrew command, network errors, CLI consent copy - #113
Merged
Merged
Conversation
added 3 commits
September 11, 2026 14:29
`brew install TeoSlayer/shell-online/shell-online` looks for the repository TeoSlayer/homebrew-shell-online, which does not exist, so the command the GitHub README offers fails on every machine. Use the three lines the landing page and llms.txt already show: tap this repository by URL, trust it, install.
The network error interpolated the accounts base URL, which is empty in every deployment, so any dropped request read "Could not reach the accounts service at . Is it running?". When the edge answered with an HTML error page, the raw JSON.parse message reached the screen instead. Name shell.online and the reader's connection, and turn an unreadable response into "Something went wrong on our side." The invite page and the audit export use the same sentence.
The consent page said only the link, the command name and the timing are published. The Terms list the full command line, host name, session name, flags, exit code and typed input, all visible to every member of the team. Spell that out in the rows and the note, say that remote start is a separate choice made in the terminal, and link the Terms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Three launch blockers from the pre-flight, one commit each.
brew install TeoSlayer/shell-online/shell-onlinelooks forTeoSlayer/homebrew-shell-online, which returns 404. The README now shows the same three lines as the landing page andllms.txt: tap this repository by URL,brew trust --tap, install.JSON.parsemessage. Both now read as sentences for the person using the app ("Could not reach shell.online. Check your connection and try again." / "Something went wrong on our side. Try again."). The invite page and the audit CSV export use the same wording.shell loginconsent page. It said "Only the link, the command name and the timing are published." The Terms list the full command line, host name, session name, flags, exit code and browser-typed input, all visible to the whole team. The page now names what the team sees and what is recorded, says remote start is a separate choice made in the terminal, and links the Terms. The vault wording from Keep session passwords in an end-to-end encrypted vault #111 is kept.Verification
npm --prefix app test: 742 passed, 3 skipped, with 6 new tests inapp/src/lib/api.test.tscovering the unreachable, HTML-502, unreadable-200, service-message, empty-500 and success pathstsc -b --forceinapp/: clean.oxlintwarnings are all in files this PR does not touchrepository 'https://github.com/TeoSlayer/homebrew-shell-online/' not found. The new three lines tap, trust, resolveteoslayer/shell-online/shell-online: stable 0.11.3, andbrew fetch --build-from-sourceverifies the tarball checksumChangelog
One entry per fix under Unreleased → Fixed.