Skip to content

Point the unreachable-relay advice at the next session, not this app - #170

Merged
Alexgodoroja merged 1 commit into
mainfrom
fix-unreachable-relay-advice
Sep 16, 2026
Merged

Alexgodoroja merged 1 commit into
mainfrom
fix-unreachable-relay-advice

Conversation

@Alexgodoroja

Copy link
Copy Markdown
Collaborator

A session on a relay this app does not proxy to was turned away with:

This session is on http://127.0.0.1:8798, but this app proxies to https://shell.online. Start it with SHELL_ONLINE_SERVER=https://shell.online to open it here.

The diagnosis is right — the app reaches exactly one relay (vite.config.ts, server/lib/relay-proxy.ts), so that session genuinely cannot be opened. The advice is not.

The subject was the app. It follows "this app proxies to …", so "start it" reads as the app. But SHELL_ONLINE_SERVER is the CLI's variable (cmd/shell/main.go:386-394); the app reads VITE_RELAY_URL / RELAY_URL (app/server/lib/config.ts:220-234). Setting the named variable on the app does nothing.

It promised something it cannot deliver. The session being turned away has usually already finished, and both "ended" and the last screen arrive over the socket (connection.ts:230,323-324). Starting anything opens a new session; this one's screen only ever existed on the relay that recorded it.

Now reads:

This session is on http://127.0.0.1:8798, but this app reaches https://shell.online, so its screen is only available where it was started. A session started with SHELL_ONLINE_SERVER=https://shell.online opens here.

The existing test still asserts both origins and the variable are named; a new one pins the change of subject so the old phrasing cannot come back.

🤖 Generated with Claude Code

A session on a relay this app does not proxy to was turned away with
"Start it with SHELL_ONLINE_SERVER=<relay> to open it here." Two things
were wrong with that sentence.

The subject was the app. It follows "this app proxies to <relay>", so
"start it" reads as the app, and SHELL_ONLINE_SERVER is not the app's
variable -- that is the CLI's. The app reads VITE_RELAY_URL, so setting
the named variable here changes nothing.

And it promised something it cannot deliver. The session being turned
away has usually already finished; starting anything opens a new
session and never recovers this one. Its screen only ever existed on
the relay that recorded it.

So say where the screen is, and offer the setting for the next session
rather than as a way back into this one.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Alexgodoroja
Alexgodoroja merged commit 9c5f6b5 into main Sep 16, 2026
15 checks passed
@Alexgodoroja
Alexgodoroja deleted the fix-unreachable-relay-advice branch September 16, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant