Point the unreachable-relay advice at the next session, not this app - #170
Merged
Merged
Conversation
A session on a relay this app does not proxy to was turned away with "Start it with SHELL_ONLINE_SERVER=<relay> to open it here." Two things were wrong with that sentence. The subject was the app. It follows "this app proxies to <relay>", so "start it" reads as the app, and SHELL_ONLINE_SERVER is not the app's variable -- that is the CLI's. The app reads VITE_RELAY_URL, so setting the named variable here changes nothing. And it promised something it cannot deliver. The session being turned away has usually already finished; starting anything opens a new session and never recovers this one. Its screen only ever existed on the relay that recorded it. So say where the screen is, and offer the setting for the next session rather than as a way back into this one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A session on a relay this app does not proxy to was turned away with:
The diagnosis is right — the app reaches exactly one relay (
vite.config.ts,server/lib/relay-proxy.ts), so that session genuinely cannot be opened. The advice is not.The subject was the app. It follows "this app proxies to …", so "start it" reads as the app. But
SHELL_ONLINE_SERVERis the CLI's variable (cmd/shell/main.go:386-394); the app readsVITE_RELAY_URL/RELAY_URL(app/server/lib/config.ts:220-234). Setting the named variable on the app does nothing.It promised something it cannot deliver. The session being turned away has usually already finished, and both "ended" and the last screen arrive over the socket (
connection.ts:230,323-324). Starting anything opens a new session; this one's screen only ever existed on the relay that recorded it.Now reads:
The existing test still asserts both origins and the variable are named; a new one pins the change of subject so the old phrasing cannot come back.
🤖 Generated with Claude Code