Skip to content

bugfix: minor tweaks and adjustments to test#66

Open
pollend wants to merge 4 commits intodevelopfrom
bugfix/resolve-unit-testing-pathfinding
Open

bugfix: minor tweaks and adjustments to test#66
pollend wants to merge 4 commits intodevelopfrom
bugfix/resolve-unit-testing-pathfinding

Conversation

@pollend
Copy link
Contributor

@pollend pollend commented Aug 30, 2021

the test area that is configured is getting clobbered when another area is declared. I make sure to properly clear the area with air blocks so the test function correctly when its evaluated again.

@pollend pollend changed the title bugfix: add cleanup to clear blocks bugfix: minor tweaks and adjustments to test Aug 30, 2021
@keturn keturn self-requested a review September 1, 2021 00:43
Copy link
Contributor

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to be excited that you figured out how to fix the tests that started failing after the gestalt-module v7 migration!

Then I looked at the test results: https://jenkins.terasology.io/teraorg/job/Terasology/job/Modules/job/P/job/Pathfinding/job/PR-66/test_results_analyzer/

This doesn't seem to be making more tests pass. If anything, there are more failures afterwards than there were before. ❓

@pollend
Copy link
Contributor Author

pollend commented Sep 1, 2021

I was about to be excited that you figured out how to fix the tests that started failing after the gestalt-module v7 migration!

Then I looked at the test results: https://jenkins.terasology.io/teraorg/job/Terasology/job/Modules/job/P/job/Pathfinding/job/PR-66/test_results_analyzer/

This doesn't seem to be making more tests pass. If anything, there are more failures afterwards than there were before. question

that's the funny thing so this change will properly clear all the blocks so its starts from empty world and re-adds those blocks for the next test. not sure why there are a few more failures. I could of selectively done this and got most of the test to pass but that doesn't seem right. Something is looking strange to me :?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants