Fix grid import status changing when allow_export is set#3
Merged
Conversation
The gridImportExport API expects a `disallow_charge_from_grid_with_solar_installed` parameter (true = disallow), but the `onoff.charge_grid` capability stores the inverted value (true = allowed). The `allow_export` listener and `flowSetAllowExport` were passing the capability value without negating it, causing the charge-from-grid setting to flip whenever the export setting was changed. https://claude.ai/code/session_011vUXXaaXMLMPQgdM18heMx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gridImportExport API expects a
disallow_charge_from_grid_with_solar_installedparameter (true = disallow), but the
onoff.charge_gridcapability stores theinverted value (true = allowed). The
allow_exportlistener andflowSetAllowExportwere passing the capability value without negating it, causing the charge-from-grid
setting to flip whenever the export setting was changed.
https://claude.ai/code/session_011vUXXaaXMLMPQgdM18heMx