Skip to content

Fix possible invalid ranges for LookUp #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyanzhong merged 1 commit into from
Jun 3, 2026
Merged

Fix possible invalid ranges for LookUp #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions TextGrabber2/Sources/Extensions/String+Extension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ extension String {
let term = self as CFString
let range = DCSGetTermRangeInString(nil, term, 0)

guard range.location != kCFNotFound && range.length > 0 else {
// Invalid range, such as (-1, 0)
return false
}

// Can be found in system dictionaries
let definition = DCSCopyTextDefinition(nil, term, range)
return definition != nil
Expand Down