Be layers list thread safe #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LabordePierre
requested changes
Nov 12, 2025
LabordePierre
approved these changes
Nov 13, 2025
LabordePierre
approved these changes
Nov 13, 2025
LabordePierre
requested changes
Nov 13, 2025
| (self layers includes: aLayer) ifTrue: [ ^ self ]. | ||
| self configureLayer: aLayer. | ||
|
|
||
| self mutex criticalReleasingOnError:[ |
| anUserObject ifNil: [ ^ self ]. | ||
|
|
||
| self layers do: [ :e | | ||
| self mutex criticalReleasingOnError:[ |
|
|
||
| self layers do: [ :e | | ||
| e haveDomainObjects ifTrue: [ e addObjects: anUserObjectList ] ] | ||
| self mutex criticalReleasingOnError:[ |
|
|
||
| "inject the projection to all layers" | ||
| self layers do:[ :l | l graphicProjection: displayToGraphicProjection ]. | ||
| self mutex criticalReleasingOnError:[ |
| (self layers includes: aLayer) ifFalse: [ ^ self ]. | ||
| self unconfigureLayer: aLayer. | ||
| self layers remove: aLayer. | ||
| self mutex criticalReleasingOnError:[ |
|
|
||
| self layers do: [ :e | | ||
| e haveDomainObjects ifTrue: [ e removeObject: anUserObject ] ] | ||
| self mutex criticalReleasingOnError:[ |
Comment on lines
612
to
615
| self mutex criticalReleasingOnError:[ | ||
| self layers do: [ :e | | ||
| e haveDomainObjects ifTrue: [ e removeObjects: anUserObjectList ] ] | ||
| ] |
| aContext ifNil:[ ^ self ]. | ||
| self layers ifEmpty: [ ^ self ]. | ||
|
|
||
| self mutex criticalReleasingOnError:[ |
LabordePierre
approved these changes
Nov 13, 2025
LabordePierre
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.