Skip to content

Add function for accessing underlying PKCS#11 keys#102

Open
nickrmc83 wants to merge 4 commits intoThalesGroup:masterfrom
nickrmc83:pkcs11-key-access
Open

Add function for accessing underlying PKCS#11 keys#102
nickrmc83 wants to merge 4 commits intoThalesGroup:masterfrom
nickrmc83:pkcs11-key-access

Conversation

@nickrmc83
Copy link
Copy Markdown
Collaborator

Add a function to allow users of this package to access underlying PKCS#11-isms so that custom extensions can be built. For example the new function could be used to wrap/export a key or unwrap/import a key using the handle associated with an existing private or secret key.

nickrmc83 added 4 commits May 9, 2023 09:37
Add a function to allow users of this package to access underlying PKCS#11-isms so that custom extensions can be built.
For example the new function could be used to wrap/export a key or unwrap/import a key using the handle associated
with an existing private or secret key.
Copy link
Copy Markdown
Contributor

@solcates solcates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@solcates solcates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlipse
Copy link
Copy Markdown

phlipse commented Apr 17, 2024

I'm interested in this PR as well. @solcates seems like you are the only reviewer. Are there any reviewers with write access to the repo left or is it not possible to merge any PR anymore?

Copy link
Copy Markdown
Contributor

@solcates solcates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solcates
Copy link
Copy Markdown
Contributor

Seems my write access has disappeared since leaving Thales. Anyone else able to help here?

@nickrmc83 nickrmc83 mentioned this pull request Jul 12, 2024
@KenGuan666
Copy link
Copy Markdown

Hi Nick @nickrmc83 Do you still intend to merge this PR?

I look forward to using the feature you added. This PR needs a rebase though. I'll make a duplicate PR with the same changes if you're no longer working on crypto11.

@IceManGreen IceManGreen self-assigned this Feb 21, 2025
@IceManGreen IceManGreen self-requested a review February 21, 2025 15:23
@IceManGreen
Copy link
Copy Markdown
Contributor

Working on it

@nickrmc83
Copy link
Copy Markdown
Collaborator Author

Hi Nick @nickrmc83 Do you still intend to merge this PR?

I look forward to using the feature you added. This PR needs a rebase though. I'll make a duplicate PR with the same changes if you're no longer working on crypto11.

I am unfortunately not a maintainer of this project any more. We'll need someone else to approve the merge.

@IceManGreen
Copy link
Copy Markdown
Contributor

Hi Nick @nickrmc83 Do you still intend to merge this PR?
I look forward to using the feature you added. This PR needs a rebase though. I'll make a duplicate PR with the same changes if you're no longer working on crypto11.

I am unfortunately not a maintainer of this project any more. We'll need someone else to approve the merge.

Hi @nickrmc83,

Thank you for your reply ! Are you still active on this PR ?
If yes, can you update your branch to follow the Go version of the main remote branch please (v1.23.6) ?
I know this PR is old but still relevant according to @KenGuan666.

@solcates
Copy link
Copy Markdown
Contributor

solcates commented Mar 1, 2025

I think @nickrmc83 and I are still active users and happy to add PR, but we do not have the right permissions to approve or merge things it seems. We both are former Thales employees, but would be willing to help out a bit with permissions.

@IceManGreen IceManGreen removed the request for review from Nicolas-Peiffer March 3, 2025 09:29
@nickrmc83
Copy link
Copy Markdown
Collaborator Author

I can look at merging master into this branch. It'll likely be in a couple of weeks though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants