Add PrivateKey object for signing, only#111
Open
mandelsoft wants to merge 2 commits intoThalesGroup:masterfrom
Open
Add PrivateKey object for signing, only#111mandelsoft wants to merge 2 commits intoThalesGroup:masterfrom
mandelsoft wants to merge 2 commits intoThalesGroup:masterfrom
Conversation
Contributor
|
Thank you @mandelsoft for your proposition, this is indeed a better approach for private keys in KMS. |
solcates
approved these changes
Jan 16, 2025
Contributor
solcates
left a comment
solcates
left a comment
There was a problem hiding this comment.
Looks good and safe to me. Thanks for the contribution.
Contributor
|
However, the code is still in @mandelsoft can you fix this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fully implementing
rsa.Signerrequires a private and public key. But if only signing is required, the private key would besufficient. Currently, the public key must be present and both must have the same Id. If one of those constraints is not satisfied signing with the private key is not possible.
Types of Changes
New Feature: introduce interface
PrivateKeywith sole signing method and provide appropriate context methods to find private keys.Verification
Create keys without Id and use new FindPrivateKey method flavors.
Testing
Tests are added.
Linked Issues
User-Facing Change
Further Comments