Add FindAllCertificates method#71
Open
mekpavit wants to merge 5 commits intoThalesGroup:masterfrom
Open
Conversation
Add FindAllCertificates method
solcates
reviewed
Sep 14, 2020
Contributor
solcates
left a comment
solcates
left a comment
There was a problem hiding this comment.
Sorry for the delayed review. LGTM, merging. Thanks for the handy contrib.
solcates
approved these changes
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request add new method
FindAllCertificateson*crypto11.Contextclass. The use case of this method is when the client doesn't know any details about certificates stored in HSM token but want to retrieve/lookup for the certificate.Changes:
FindAllCertificatesmethod. The code is based onFindCertificateand was edited for the new functionality. The code duplication betweenFindCertificateandFindAllCertificatescan be removed but I think it's fine to leave it like this for now.TestFindAllCertificatesfunction incertificates_test.goto testFindAllCertificatesmethodremoveAllCertificatesincertificates_test.gohelper function that find and remove all certificates in the tokenremoveAllCertificates()at the end of each test cases incertificates_test.goto make each case independent of each other