add salt length calculation with PSSSaltLengthAuto#96
Open
maraino wants to merge 1 commit intoThalesGroup:masterfrom
Open
add salt length calculation with PSSSaltLengthAuto#96maraino wants to merge 1 commit intoThalesGroup:masterfrom
maraino wants to merge 1 commit intoThalesGroup:masterfrom
Conversation
When PSSSaltLengthAuto is set, the maximum salt length must equal: (modulus_key_size - 1 + 7)/8 - hash_length - 2 For example, for a 4096-bit modules key and SHA256 it should be: (4096 - 1 + 7)/8 - 32 - 2 = 478 See https://golang.org/cl/302230
maraino
changed the title
Contributor
Author
|
@solcates, are you maintaining this repo? Any updates on this? |
optnfast
approved these changes
Aug 15, 2022
Contributor
optnfast
left a comment
optnfast
left a comment
There was a problem hiding this comment.
The change looks good to me.
Contributor
Author
Contributor
|
@solcates would be my first thought but I no longer work for Thales so I don't really know. |
solcates
approved these changes
Feb 18, 2024
Contributor
solcates
left a comment
solcates
left a comment
There was a problem hiding this comment.
Sorry, I haven't been checking up on this code like I should have
LGTM
Contributor
Author
@solcates is it possible to merge this and tag a new version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for signing using rsa.PSSSaltLengthAuto
When PSSSaltLengthAuto is set, the maximum salt length must equal:
(modulus_key_size - 1 + 7)/8 - hash_length - 2
For example, for a 4096-bit modules key and SHA256 it should be:
(4096 - 1 + 7)/8 - 32 - 2 = 478
See https://golang.org/cl/302230