Skip to content

Add support for snapshots and interactive console#5

Open
Typhlos wants to merge 11 commits intoThalesGroup:mainfrom
Typhlos:main
Open

Add support for snapshots and interactive console#5
Typhlos wants to merge 11 commits intoThalesGroup:mainfrom
Typhlos:main

Conversation

@Typhlos
Copy link
Copy Markdown

@Typhlos Typhlos commented Apr 18, 2023

These commits add support for:

  • Creating, listing and restoring snapshots
  • Opening an interactive console

@IceManGreen IceManGreen self-assigned this May 5, 2023
@IceManGreen IceManGreen added the enhancement New feature or request label May 5, 2023
@IceManGreen
Copy link
Copy Markdown
Contributor

@Typhlos please provide more information about :

  • ✅ the behavior of the feature you implemented (summary)
  • ❌ the commands that trigger your new feature
  • ❌ the expected state / logs / results of the feature execution (some technical details)

@Typhlos
Copy link
Copy Markdown
Author

Typhlos commented May 11, 2023

This pull request provides 4 new cli commands :

freyja machine console vm

It opens an interactive console in the specified vm. It returns an error if the vm is not found.

freyja machine snapshot vm snapshot_name

Creates a snapshot with the specified name of the specified vm. It returns nothing on success and returns an error if the vm is not found.

freyja machine restore vm snapshot_name

Restores a snapshot with the specified name of the specified vm. It asks for confirmation. It returns nothing on success and returns an error if the vm or the snapshot is not found.

freyja machine list-snapshots vm

Lists all the available snapshots of the specified vm. It returns an error if the vm is not found.

This PR also updates the documentation to add those cli commands.

@IceManGreen
Copy link
Copy Markdown
Contributor

Implementation is good.

@Typhlos the commits :

  • d8e9d84
  • 4e34ea5
  • 080cc84

misses your signature.

Proceedure :

  • configure your signing key for git commits
  • run git rebase --exec 'git commit --amend --no-edit -n -S -s' -i <commit hash>

@Typhlos
Copy link
Copy Markdown
Author

Typhlos commented Jun 21, 2024

Implementation is good.

@Typhlos the commits :

  • d8e9d84
  • 4e34ea5
  • 080cc84

misses your signature.

Proceedure :

  • configure your signing key for git commits
  • run git rebase --exec 'git commit --amend --no-edit -n -S -s' -i <commit hash>

It should be done

Typhlos and others added 9 commits June 21, 2024 11:32
Signed-off-by: Martin Spiering <martin.spiering@s3ns.io>
Signed-off-by: Martin Spiering <martin.spiering@thalesgroup.com>
Signed-off-by: Martin Spiering <martin.spiering@s3ns.io>
Signed-off-by: Martin Spiering <martin.spiering@s3ns.io>
Signed-off-by: Martin Spiering <martin.spiering@s3ns.io>
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.2...3.1.3)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Martin Spiering <martin.spiering@s3ns.io>
Signed-off-by: Louis Cailliot <louis.cailliot@thalesgroup.com>
Signed-off-by: Martin Spiering <martin.spiering@s3ns.io>
Signed-off-by: Louis Cailliot <louis.cailliot@thalesgroup.com>
Signed-off-by: Martin Spiering <martin.spiering@s3ns.io>
Bumps [pydantic](https://github.com/pydantic/pydantic) from 1.10.5 to 1.10.13.
- [Release notes](https://github.com/pydantic/pydantic/releases)
- [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
- [Commits](pydantic/pydantic@v1.10.5...v1.10.13)

---
updated-dependencies:
- dependency-name: pydantic
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Martin Spiering <martin.spiering@s3ns.io>
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.3...3.1.4)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Martin Spiering <martin.spiering@s3ns.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants