refacto(docker): Download Node.js binaries directly#394
Open
midnya wants to merge 1 commit into
Open
Conversation
midnya
commented
Sep 28, 2025
midnya
commented
- Bypasses the deprecation warning from the convenience script; which is a good QoL for end users.
- Prevent rebuild on any non meaningful-file change (by only copying ./app).
- Does not clone the repository again; which allows for forks and branching
- Also, upgrades uses Debian 12 as the base image; this can be changed to an equivalent Ubuntu one if desired. The way Node.js is installed here is resilient to this kind of image swap.
- While Meteor will not build for aarch64 now, the way Node.js is installed here will work for amd64 and aarch64.
- Bypasses the deprecation warning from the convenience script; which is a good QoL for end users. - Prevent rebuild on any non meaningful-file change (by only copying ./app). - Does not clone the repository *again*; which allows for forks and branching - Also, upgrades uses Debian 12 as the base image; this can be changed to an equivalent Ubuntu one if desired. The way Node.js is installed here is resilient to this kind of image swap. - While Meteor will not build for aarch64 *now*, the way Node.js is installed here will work for amd64 and aarch64.
|
|
|
Nice one @ShinySaana! I’ll give it a try on a branch of my fork. I had also made some tweaks to the Dockerfile a while back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.