Skip to content

mpl: update one usage of odb to src/db in bzl#10423

Closed
maliberty wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:mpl-bzl-fix
Closed

mpl: update one usage of odb to src/db in bzl#10423
maliberty wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:mpl-bzl-fix

Conversation

@maliberty
Copy link
Copy Markdown
Member

Summary

update one usage of odb to src/db in bzl

Type of Change

  • Bug fix

Impact

Fixes

ERROR: /Users/runner/work/OpenROAD/OpenROAD/src/mpl/BUILD:31:11: no such target '//src/odb:odb': target 'odb' not declared in package 'src/odb' defined by /Users/runner/work/OpenROAD/OpenROAD/src/odb/BUILD and referenced by '//src/mpl:pusher'

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • [ x My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty requested a review from a team as a code owner May 13, 2026 21:26
@maliberty maliberty self-assigned this May 13, 2026
@maliberty maliberty requested a review from AcKoucher May 13, 2026 21:26
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependency in the src/mpl/BUILD file, specifically changing the reference from //src/odb to //src/odb/src/db. There are no review comments to evaluate, and I have no feedback to provide regarding these changes.

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus
Copy link
Copy Markdown
Member

I didn't notice your PR before creating this one: #10424.

I think the bazel BUILD file under mpl/test needs update as well.

@maliberty maliberty closed this May 13, 2026
@maliberty maliberty deleted the mpl-bzl-fix branch May 13, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants