Skip to content

fix: propagate exception from verified inline comment publishing #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karesansui-u wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix: propagate exception from verified inline comment publishing #2258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d7253
fix: propagate exception from verified inline comment publishing
karesansui-u Mar 16, 2026
c534e99
fix: remove duplicate error log, let caller handle logging
karesansui-u Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pr_agent/git_providers/github_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,8 +475,8 @@ def _publish_inline_comments_fallback_with_verification(self, comments: list[dic
if verified_comments:
try:
self.pr.create_review(commit=self.last_commit_id, comments=verified_comments)
except:
pass
except Exception:
raise

# try to publish one by one the invalid comments as a one-line code comment
if invalid_comments and get_settings().github.try_fix_invalid_inline_comments:
Expand Down